-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Android TV #939
[WIP] Android TV #939
Conversation
Looks awesome O.o |
@theScrabi: The code isn't updated to Android 27 yet, so the build will fail. Without TeamNewPipe/NewPipeExtractor#55 it doesn't show New & hot. Also please use Besides that, Travis needs to use the correct build commands (now they contain |
The build passed for me, I could run it. However I had to change about 4 lines of code for that.
Right fixed that. |
@theScrabi: You don't have to run the normal ones on Travis, since tv is a superset of normal. Btw what lines of code did you change for that? I still see the MediaPlayerGlue, which is deprecated in 27. |
It is that is true, but still worked. |
By the way what is the status of this project? |
Well, I'm on a holiday in Germany ;)
|
Ah cool. Well have a nice time then 😉 |
@wb9688 Will this also work for FireTV or is that a separate project? I'm an Android TV user but I bet there's more FireTV users out there right now. |
@cormak: Fire TV is just Android TV, but with some small extra features.
This means Android TV apps will automatically also work on Fire TV, but
without those small extras, until you also add support for them.
|
@wb9688 Are those small extras worth adding for FireTV users? FireTV users are currently without a Youtube app so I can see Newpipe exploding in popularity once every TV box can sideload Newpipe and get a TV-friendly UI, so this is a very exciting PR. |
Actually the idea of this project was to support fireTV :) |
@o-l-a-v suggested some icons here.
I'll try to make a black / dark one too. Another idea is to use some kind of the triangle like in the F-Droid banner. Unfortunately I don't have any Android TV so I can't see whether the font size is large enough, but compared to the default videos launcher icon it seems good to me. Maybe @bagelcake can help us too as he already made the F-Droid banner. |
Unfortunately I don't have any Android TV
Can't you run it in an emulator? That should give you a pretty good idea I
think.
|
Yes, I did. But that does not make my screen larger. |
Oh, yeah, that's right. My monitor is 32" though, so I forgot that. |
@TobiGr Number 2 is definitely the best one. Fits in the best with existing Android TV icons for other apps. |
We're doing that, but we also have a mobile-only APK, since TV supports
only from a certain Android version, while regular NewPipe also supports
from a lower Android version and we want those users still to be able to
use NewPipe.
|
Hey guys, |
Even if I feel something missing, I love 5a and 5b |
The shadow and the font feel 'off'. What font are you using? Try Roboto.
Btw I should finish this PR, but I've been really busy.
|
Yes, I didn't draw much attention to the shadows. I am using Arial right now. Roboto sounds good. I actually thought about using it for the website some time ago. |
I too think 5.a looks the best but is missing something, perhaps combine 1.a's icon with 5.a's background? |
4 or 5.a :) |
More 4 |
@TobiGr I think 2 would be the best one if the font were Roboto. I don't see the point of putting a round touch icon in a square TV icon. The Newpipe logo shouldn't be encircled by anything else. The other icons look too busy. Newpipe should be clean, easy to read, and distinctive while still keeping a uniform red color. |
I think those, especially the all read ones, look like the netflix tile/ leanback icon. |
Well and the newpipe logo looks like german arbeitsamt. 😂 I don't know I think the 4 is good. Wed just had to remove the shadow beneath the font so it does not look to much like netflix. |
I don't know I liked the little bits in the background. Is that to much netflix, if not 4. was awsome. I'd take 4. After all the icon is the least we have to concert when we build this. |
Thanks for the feedback. I'll improve the logos and come back with new ideas soon. @o-l-a-v I wouldn't split the name into two words. People should recognize the app, its name and the colors so they can identify with them. |
You should maybe try to add lightening effects () |
Hi, Where I can find this apk? I have a xiaomi Android Tv and I would like try on this box. Thanks. |
@milencollin: Nowhere, since it isn't even close to finished.
|
@wb9688 oh ok! If you need beta tester I can do it to help you ;) |
abandoned ... at least for now. Maybe we can catch up with this later on. |
Just wanted to add that Android TV support with a UI designed for large screens would be very welcome, thanks for you initial work on this already! |
I think the best solution was to make the current UI responsive for tv. We are already working on that :) |
Alghtough help for d-pad support was welcome. |
I've added an initial Android TV version (#899). It looks like the following:
Things to do:
dev
into it (I started working on this some time ago and today was the first day I had time for this again)@theScrabi: Could you test if it runs (just the main screen) on your Fire TV?