Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Android TV #939

Closed
wants to merge 4 commits into from
Closed

[WIP] Android TV #939

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2017

I've added an initial Android TV version (#899). It looks like the following:

Screenshot

Things to do:

  • Merge dev into it (I started working on this some time ago and today was the first day I had time for this again)
  • Make it possible to watch the videos
  • Implement search
  • Add real settings
  • Add TV flavor to F-Droid (@theScrabi? Btw I've to test first if it doesn't crash on an Android phone, since F-Droid has no way to detect Android TV, but prioritizes the flavor with the highest min API version)
  • Clean up code
  • Design logo (@TobiGr?)

@theScrabi: Could you test if it runs (just the main screen) on your Fire TV?

@theScrabi
Copy link
Member

Looks awesome O.o

@theScrabi theScrabi changed the title Android TV [WIP] Android TV Dec 24, 2017
@ghost
Copy link
Author

ghost commented Dec 24, 2017

@theScrabi: The code isn't updated to Android 27 yet, so the build will fail. Without TeamNewPipe/NewPipeExtractor#55 it doesn't show New & hot. Also please use tvImplementation instead of tvCompile.

Besides that, Travis needs to use the correct build commands (now they contain tv in it).

@theScrabi
Copy link
Member

The code isn't updated to Android 27 yet, so the build will fail.

The build passed for me, I could run it. However I had to change about 4 lines of code for that.

Also please use tvImplementation instead of tvCompile.

Besides that, Travis needs to use the correct build commands (now they contain tv in it).

Right fixed that.

@ghost
Copy link
Author

ghost commented Dec 24, 2017

@theScrabi: You don't have to run the normal ones on Travis, since tv is a superset of normal.

Btw what lines of code did you change for that? I still see the MediaPlayerGlue, which is deprecated in 27.

@theScrabi
Copy link
Member

I still see the MediaPlayerGlue, which is deprecated in 27.

It is that is true, but still worked.
It's these linese.

@theScrabi
Copy link
Member

@wb9688 Someone at 34c3 wrote an app called chaosflix maybe we can take his code as a template for our own leanback UI.

@theScrabi
Copy link
Member

By the way what is the status of this project?

@ghost
Copy link
Author

ghost commented Jan 3, 2018 via email

@theScrabi
Copy link
Member

Ah cool. Well have a nice time then 😉

@ghost
Copy link
Author

ghost commented Jan 11, 2018

@wb9688 Will this also work for FireTV or is that a separate project? I'm an Android TV user but I bet there's more FireTV users out there right now.

@ghost
Copy link
Author

ghost commented Jan 11, 2018 via email

@ghost
Copy link
Author

ghost commented Jan 11, 2018

@wb9688 Are those small extras worth adding for FireTV users?

FireTV users are currently without a Youtube app so I can see Newpipe exploding in popularity once every TV box can sideload Newpipe and get a TV-friendly UI, so this is a very exciting PR.

@theScrabi
Copy link
Member

Actually the idea of this project was to support fireTV :)

@TobiGr
Copy link
Contributor

TobiGr commented Jan 20, 2018

@o-l-a-v suggested some icons here.
@wb9688 @theScrabi I just made a first try and got these three. Please tell me what kind of logo you like more. They are in a really early state and I am going to finish them later.

  1. white (I need to correct the icon's shadow direction)
  2. red (needs some more space between New and Pipe)
  3. red

I'll try to make a black / dark one too. Another idea is to use some kind of the triangle like in the F-Droid banner. Unfortunately I don't have any Android TV so I can't see whether the font size is large enough, but compared to the default videos launcher icon it seems good to me.

Maybe @bagelcake can help us too as he already made the F-Droid banner.

@ghost
Copy link
Author

ghost commented Jan 20, 2018 via email

@TobiGr
Copy link
Contributor

TobiGr commented Jan 20, 2018

Can't you run it in an emulator?

Yes, I did. But that does not make my screen larger.

@ghost
Copy link
Author

ghost commented Jan 20, 2018

Oh, yeah, that's right. My monitor is 32" though, so I forgot that.

@ghost
Copy link
Author

ghost commented Jan 21, 2018

@TobiGr Number 2 is definitely the best one. Fits in the best with existing Android TV icons for other apps.

@ghost
Copy link
Author

ghost commented Jan 21, 2018 via email

@TobiGr
Copy link
Contributor

TobiGr commented Feb 4, 2018

Hey guys,
here is a quick second round with some more random ideas for a launcher icon. They are all not perfect (many need more margin to the right side) but I want to show you other ideas to get an idea in which direction I should go on. So please give me feedback about what you liked and also what not.

1. a
1. b
2.
3.
4.
5. a
5. b

@justanidea
Copy link
Contributor

Even if I feel something missing, I love 5a and 5b

@ghost
Copy link
Author

ghost commented Feb 4, 2018 via email

@TobiGr
Copy link
Contributor

TobiGr commented Feb 4, 2018

Yes, I didn't draw much attention to the shadows. I am using Arial right now. Roboto sounds good. I actually thought about using it for the website some time ago.

@karyogamy
Copy link
Contributor

I too think 5.a looks the best but is missing something, perhaps combine 1.a's icon with 5.a's background?

@theScrabi
Copy link
Member

4 or 5.a :)

@theScrabi
Copy link
Member

More 4

@ghost
Copy link
Author

ghost commented Feb 5, 2018

@TobiGr I think 2 would be the best one if the font were Roboto. I don't see the point of putting a round touch icon in a square TV icon. The Newpipe logo shouldn't be encircled by anything else. The other icons look too busy. Newpipe should be clean, easy to read, and distinctive while still keeping a uniform red color.

@o-l-a-v
Copy link

o-l-a-v commented Feb 5, 2018

I think those, especially the all read ones, look like the netflix tile/ leanback icon.
I like my idea, looks more "NewPipe" and "Android TV" IMHO. And, Roboto font.
Image
All files (including photoshop and paint.net project files for further editing):
NewPipe_Leanback.zip

@theScrabi
Copy link
Member

Well and the newpipe logo looks like german arbeitsamt. 😂 I don't know I think the 4 is good. Wed just had to remove the shadow beneath the font so it does not look to much like netflix.

@o-l-a-v
Copy link

o-l-a-v commented Feb 5, 2018

Image
^ More like this maybe?

@theScrabi
Copy link
Member

theScrabi commented Feb 6, 2018

I don't know I liked the little bits in the background. Is that to much netflix, if not 4. was awsome.

I'd take 4. After all the icon is the least we have to concert when we build this.

@TobiGr
Copy link
Contributor

TobiGr commented Feb 6, 2018

Thanks for the feedback. I'll improve the logos and come back with new ideas soon.
Btw. I didn't see any conflict between Netflix' and our logo but I'll try to avoid it in the future 😅

@o-l-a-v I wouldn't split the name into two words. People should recognize the app, its name and the colors so they can identify with them.

@justanidea
Copy link
Contributor

You should maybe try to add lightening effects ()

@milencollin
Copy link

Hi,

Where I can find this apk? I have a xiaomi Android Tv and I would like try on this box.

Thanks.

@ghost
Copy link
Author

ghost commented Mar 12, 2018 via email

@milencollin
Copy link

@wb9688 oh ok! If you need beta tester I can do it to help you ;)

@theScrabi theScrabi closed this Apr 12, 2018
@theScrabi
Copy link
Member

abandoned ... at least for now. Maybe we can catch up with this later on.

@h-2
Copy link

h-2 commented Oct 1, 2018

Just wanted to add that Android TV support with a UI designed for large screens would be very welcome, thanks for you initial work on this already!

@theScrabi
Copy link
Member

I think the best solution was to make the current UI responsive for tv. We are already working on that :)

@theScrabi
Copy link
Member

Alghtough help for d-pad support was welcome.

@theScrabi theScrabi deleted the android-tv branch October 8, 2018 10:36
@TobiGr TobiGr mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants