Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add french README #9296

Closed
wants to merge 11 commits into from

Conversation

eze-kiel
Copy link
Contributor

@eze-kiel eze-kiel commented Nov 4, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing) -> doc improvement
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR adds the full french README (doc/README.fr.md, and adds its link in README.md at the root of the repo.

Before/After Screenshots/Screen Record

  • Before:
  • After:
See screenshot

image

Fixes the following issue(s)

No code fixes.

APK testing

No need as the code is not impacted by this PR.

Due diligence

@AudricV AudricV added meta Related to the project but not strictly to code localisation / translation Everything that has to do with translations or Weblate labels Nov 4, 2022
@AudricV AudricV mentioned this pull request Nov 4, 2022
5 tasks
Copy link

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found some typos, otherwise looks great!

doc/README.fr.md Outdated Show resolved Hide resolved
doc/README.fr.md Outdated Show resolved Hide resolved
@eze-kiel
Copy link
Contributor Author

eze-kiel commented Nov 4, 2022

Nice catches! I'm fixing them right now

@eze-kiel eze-kiel requested a review from BrightDV November 4, 2022 18:16
Copy link

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have switched to my computer and found some other small typos.
Also, you should add the link to french READMe inside the others READMEs (not only in the english one).
After that, it looks go to me!

doc/README.fr.md Outdated Show resolved Hide resolved
doc/README.fr.md Outdated Show resolved Hide resolved
doc/README.fr.md Outdated Show resolved Hide resolved
@eze-kiel
Copy link
Contributor Author

eze-kiel commented Nov 6, 2022

hi @BrightDV, thanks for your review!
it should be good this time :)

@eze-kiel eze-kiel requested a review from BrightDV November 6, 2022 17:17
Copy link

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes !

@BrightDV
Copy link

BrightDV commented Jan 3, 2023

Can someone merge this, please?

TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9296 with updated screenshots

Co-authored-by: eze-kiel <[email protected]>
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9296 with updated screenshots

Co-authored-by: eze-kiel <[email protected]>
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9296 with updated screenshots

Co-authored-by: eze-kiel <[email protected]>
@TobiGr TobiGr mentioned this pull request Jul 17, 2023
5 tasks
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9296 with updated screenshots

Co-authored-by: eze-kiel <[email protected]>
@TobiGr
Copy link
Contributor

TobiGr commented Jul 17, 2023

Thank you for your work. Your changes were merged in #10240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants