-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add french README #9296
docs: add french README #9296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found some typos, otherwise looks great!
Nice catches! I'm fixing them right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have switched to my computer and found some other small typos.
Also, you should add the link to french READMe inside the others READMEs (not only in the english one).
After that, it looks go to me!
hi @BrightDV, thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes !
Can someone merge this, please? |
Taken from #9296 with updated screenshots Co-authored-by: eze-kiel <[email protected]>
Taken from #9296 with updated screenshots Co-authored-by: eze-kiel <[email protected]>
Taken from #9296 with updated screenshots Co-authored-by: eze-kiel <[email protected]>
Taken from #9296 with updated screenshots Co-authored-by: eze-kiel <[email protected]>
Thank you for your work. Your changes were merged in #10240 |
What is it?
Description of the changes in your PR
This PR adds the full french README (
doc/README.fr.md
, and adds its link inREADME.md
at the root of the repo.Before/After Screenshots/Screen Record
See screenshot
Fixes the following issue(s)
No code fixes.
APK testing
No need as the code is not impacted by this PR.
Due diligence