Use ListAdapter for search predictions. #8719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
from
ee7fd73 to
f455f92
Compare
TacoTheDank
requested changes
Jul 31, 2022
app/src/main/java/org/schabi/newpipe/fragments/list/search/SuggestionListAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java
Outdated
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
5 times, most recently
from
a058b45 to
e2e0be4
Compare
Stypox
previously requested changes
Aug 4, 2022
There was a problem hiding this comment.
Good changes! I'll let @TacoTheDank complete the review and merge
app/src/main/java/org/schabi/newpipe/settings/preferencesearch/PreferenceSearcher.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/preferencesearch/PreferenceSearchAdapter.java
Show resolved
Hide resolved
triallax
added
feature request
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
2 times, most recently
from
e6ee5b0 to
1c5bdee
Compare
5 tasks
|
Sorry, I took a small break over the past week to relax after the past semester. Could this be rebased to remove the dev merge commit? |
Sure. |
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
from
b591373 to
c6fb180
Compare
|
@Stypox Are we doing a feature freeze until v0.24.0 is released, or can this be merged now? |
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
2 times, most recently
from
27dda7e to
72b6fbb
Compare
|
No, we have not decided upon a freeze, you can proceed @TacoTheDank |
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
from
72b6fbb to
a4d99b9
Compare
Isira-Seneviratne
force-pushed
the
Use_ListAdapter
branch
from
a4d99b9 to
5e0788b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
TacoTheDank
approved these changes
Aug 19, 2022
|
Thanks for this feature! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
ListAdapterto handle displaying list data inPeertubeInstanceListFragment,SuggestionListAdapterandPreferenceSearchAdapter.Before/After Screenshots/Screen Record
device-2022-07-31-155131.mp4
device-2022-08-01-061212.mp4
device-2022-07-31-155211.mp4
device-2022-08-01-061232.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence