Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume progress bar match system volume when we start sliding #8377

Merged
merged 1 commit into from
May 9, 2022

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented May 9, 2022

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

This PR makes the volume progress bar (the slider used to change the volume) match the system volume when we start sliding. Otherwise, the slider would remember its last position, and the system volume would be ignored.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels May 9, 2022
@AudricV AudricV changed the title make volume progress bar match system volume when we start sliding Make volume progress bar match system volume when we start sliding May 9, 2022
@iTrooz
Copy link
Contributor Author

iTrooz commented May 9, 2022

I wanted to remove the blank lines. Sorry I still have trouble with git sometimes

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

@Redirion Redirion merged commit a4037a8 into TeamNewPipe:dev May 9, 2022
@Stypox Stypox mentioned this pull request Jun 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume slider do not take into account actual system volume
3 participants