-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix history view count #8336
Fix history view count #8336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! What a simple change :-)
app/src/main/java/org/schabi/newpipe/database/history/model/StreamHistoryEntity.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Stypox <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Unfortunately, this was too easy... Now when contents are enqueued, they are saved in the history, but without any view! The corresponding history entries just say @Mamadou78130 Do you want to care of this, or should it be fixed by someone else or reverted? |
@TiA4f8R Anyway, could you open a new issue for that, so we can discuss it there? :) |
@litetex Sorry, I think I wasn't clear in my comment, that's why you misunderstood my sentence: this happens when they are enqueued and after they have been played, so it is a regression. Free feel to open an issue yourself about this regression :) |
@Mamadou78130 see #8564 for an actual fix, but thank you anyway for this PR :-) |
What is it?
Description of the changes in your PR
When watching a video that you have not seen before and going to the history.
Note that the history entry shows 2 views instead of 1 view for said video.
I then modified a function to solve the problem.
So when we go to the video history we see that he has 1 marked view.
Before/After Screenshots/Screen Record
Before:
![Capture d’écran du 2022-05-02 15-25-46](https://user-images.githubusercontent.com/92532045/166241927-4a04afbc-aae9-4279-a110-1726fc2263e3.png)
After:
![Capture d’écran du 2022-05-02 15-24-11](https://user-images.githubusercontent.com/92532045/166241944-b211d5e4-c348-423e-9ccb-9530d6bdcc1b.png)
Fixes the following issue(s)
Test Manuel
Due diligence