Removed unused `strings.xml` resources #8329

litetex · 2022-05-01T18:53:14Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

I recently noticed that the following warning:

> Task :app:compressDebugAssets
warn: removing resource org.schabi.newpipe.debug:string/adjust_by_semitones_checkbox without required default value.
warn: removing resource org.schabi.newpipe.debug:string/background_player_already_playing_toast without required default value.
warn: removing resource org.schabi.newpipe.debug:string/error_show_channel_details without required default value.
warn: removing resource org.schabi.newpipe.debug:string/loading_channel_details without required default value.
warn: removing resource org.schabi.newpipe.debug:string/playback_tempo_step without required default value.
warn: removing resource org.schabi.newpipe.debug:string/report_player_errors_summary without required default value.
warn: removing resource org.schabi.newpipe.debug:string/report_player_errors_title without required default value.
warn: removing resource org.schabi.newpipe.debug:string/settings_category_notification_title without required default value.
warn: removing resource org.schabi.newpipe.debug:string/yes without required default value.

Looks like these warnings got in there since we merged Weblate in the latest release.
Anyway, I removed the affected unused strings to get rid of them.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.