Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newInstance in PlaylistDialog #8146

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Use newInstance in PlaylistDialog #8146

merged 1 commit into from
Apr 10, 2022

Conversation

GGAutomaton
Copy link
Contributor

@GGAutomaton GGAutomaton commented Apr 4, 2022 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • delete the constructors in PlaylistDialog
  • use newInstance() instead

See https://stackoverflow.com/questions/51831053/could-not-find-fragment-constructor

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@GGAutomaton
Copy link
Contributor Author

Reproduction steps:

  1. Open any video and press "add to playlist"
  2. Rotate the screen

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

TacoTheDank
TacoTheDank approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@TacoTheDank TacoTheDank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this fixes the issue. Looks good to me 👍

@opusforlife2 opusforlife2 added the bug Issue is related to a bug label Apr 9, 2022
litetex
litetex approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex merged commit 74c9a3d into TeamNewPipe:dev Apr 10, 2022
@Stypox Stypox mentioned this pull request Apr 16, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TacoTheDank TacoTheDank TacoTheDank approved these changes

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI error crash when rotating screen while "add to playlist" modal is open.
4 participants
@GGAutomaton @TacoTheDank @litetex @opusforlife2