Image preview in Android share sheet (Android 10+ only) #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
feature request
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
reviewed
Apr 30, 2022
| * | ||
| * @param context the context to use | ||
| * @param intent the intent to open | ||
| * @param isShareIntent set the title "Open with" to the chooser if true, else not |
There was a problem hiding this comment.
Suggested change
| * @param isShareIntent set the title "Open with" to the chooser if true, else not | |
| * @param isShareIntent set the title "Open with" to the chooser if false, else do not set any title |
AudricV
force-pushed
the
image-preview-sharesheet
branch
from
734825a to
0455093
Compare
These previews will be only available for images cached in the cache used by Picasso. The Bitmap of the content is compressed in JPEG 90 and saved inside the application cache folder under the name android_share_sheet_image_preview.jpg. The current image will be, of course, always overwritten by the next one and cleared when the application cache is cleared.
AudricV
force-pushed
the
image-preview-sharesheet
branch
from
0455093 to
761c0ff
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
May 22, 2022
Stypox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR adds the image preview of contents shared in the Android share sheet, for Android 10+ devices. Note that it may be not shown, depending of the customizations made by your OEM on your Android device.
Images included in the share sheet will be only the ones in the memory image cache used by Picasso (the image library loader), in order to not have to handle network exceptions when sharing contents. If it is not loaded or no image preview is available, no image will be shown in the share sheet (like the current behavior).
The image of the content, before sharing, is compressed in JPEG 90 and saved inside the application cache folder under the name
android_share_sheet_image_preview.jpg. The current image shared will be, of course, always overwritten by the next one and deleted when the application cache is cleared.Before/After Screenshots/Screen Record
Fixes the following issue(s)
Fixes the TODO (that I added) in
ShareUtils:NewPipe/app/src/main/java/org/schabi/newpipe/util/external_communication/ShareUtils.java
Lines 255 to 261 in 629b685
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence