Fix fetch of video streams (when switching between tracks in a play queue) and subtitles when using a seamless transition between background and video players #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueue) and subtitles when using a seamless transition between background and video players Make the use of the new method setDisabledTrackTypes in DefaultTrackSelector.ParametersBuilder, which disables selection of tracks type for every TrackGroup instead of the current group, which is the current behavior. This removes the use of the deprecated of setSelectionOverride method. Note that for progressive media, the content is still fetched, but only for initialization purposes (so requests are pretty small, most of times with a few kilobytes size).
AudricV
added
bug
|
I really appreciate your effort to make this PR testable, however the code change looks clean and small enough to assess that this can be merged without issues as it is basically just affecting the background player. I like it and would like to merge it. Please remove the testing code. Thank you! :) |
|
Done :) |
AudricV
force-pushed
the
seamless-transition-video-subtitles-fetch-fix
branch
from
ed45295 to
3261855
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When doing #7349, I didn't notice, when switching tracks in a play queue, that the video stream was renabled and was so fetched in background. This PR fixes this, and thanks to the method
setDisabledTrackTypesinDefaultTrackSelector.ParametersBuilder, now available because we are using the latest version of ExoPlayer, we can now easily disable video tracks in background for all streams in a play queue (even if they can be fetched for initialization purposes (requests tends to turn around some kilobytes), which is the case forProgressiveMediaSources, right now used to fetch all contents in the app).I also didn't noticed that subtitles were still fetched in background, which is now fixed too with this PR.
Remember that if you want a real background player when pausing the app, you have to use the
Backgroundcommand.Fixes the following issue(s)
No issue was opened for these bugs.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence