Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Revert MediaParser support (Android 11+) due to bugs #7555

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Remove/Revert MediaParser support (Android 11+) due to bugs #7555

merged 1 commit into from
Dec 22, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Dec 19, 2021 •
edited by AudricV
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex mentioned this pull request Dec 19, 2021
Closed
4 tasks
@litetex litetex marked this pull request as ready for review December 20, 2021 15:14
@litetex litetex added bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software youtube Service, https://www.youtube.com/ labels Dec 20, 2021
@AudricV AudricV added the player Issues related to any player (main, popup and background) label Dec 20, 2021
@AudricV AudricV changed the title Removed/Reverted MediaParser support (Android 11+) due to bugs Remove/Revert MediaParser support (Android 11+) due to bugs Dec 20, 2021
Redirion
Redirion approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Redirion Redirion merged commit f6cad2d into TeamNewPipe:dev Dec 22, 2021
@AudricV AudricV mentioned this pull request Dec 22, 2021
Closed
4 tasks
@Danielmb87
Copy link

Apk resolved the issue for me

@its-me-ben
Copy link

Seems to have fixed it for me! Good job, people!

@AudricV AudricV mentioned this pull request Dec 24, 2021
Closed
9 tasks
@litetex litetex deleted the remove-mediaparser branch December 24, 2021 20:22
@litetex litetex mentioned this pull request Dec 31, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Redirion Redirion Redirion approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background) youtube Service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video stops playing at around the end part of videos
5 participants
@litetex @Danielmb87 @its-me-ben @Redirion @AudricV