Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking timestamp shows Toast "Playing in popup mode" #7202

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

vhouriet
Copy link
Contributor

@vhouriet vhouriet commented Oct 5, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • "Playing in popup mode" toast no longer appear when clicking timestamps if the player is already in popup mode.

Before/After Screenshots/Screen Record

  • Before:
before.mp4
  • After:
after.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Oct 5, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

LGTM

Maybe we should also add such an check to the background player in the future.

@vhouriet
Copy link
Contributor Author

vhouriet commented Oct 9, 2021

@litetex Seems like a good idea, I'll look into it. Should I open an issue for it first ?

@litetex
Copy link
Member

litetex commented Oct 10, 2021

Should I open an issue for it first ?

How you want. Opening a PR without an issue also works 😄

@litetex litetex merged commit e9bd293 into TeamNewPipe:dev Oct 11, 2021
@vhouriet vhouriet deleted the vhouriet_bug_issue-6662 branch October 21, 2021 13:21
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking timestamp shows Toast "Playing in popup mode", even if the player is already in popup mode.
3 participants