Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore paths unrelated to builds in CI (#6789)" #7182

Closed
wants to merge 1 commit into from

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Sep 28, 2021

This reverts commit c7f75bf.

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The repo settings currently require a PR's status checks to complete without failure for it to be merged. However, GitHub currently doesn't take into account that for some PRs the checks will never run, since all the files modified are paths-ignored. You can see an instance of this problem in #7165.

Due diligence

@TobiGr @opusforlife2

@triallax triallax added bug Issue is related to a bug CI Everything related to CI (Continuous integration) labels Sep 28, 2021
@litetex
Copy link
Member

litetex commented Sep 28, 2021

Why don't we simply disable the required check?
(I have no rights to do so but someone should)

@triallax
Copy link
Contributor Author

@TobiGr what do you think about @litetex's suggestion?

@TobiGr
Copy link
Contributor

TobiGr commented Oct 2, 2021

Ok. I disabled required checks for dev

@TobiGr TobiGr closed this Oct 2, 2021
@opusforlife2 opusforlife2 deleted the revert-6789-no-ci-on-readme-changes branch October 2, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug CI Everything related to CI (Continuous integration)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants