-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement resizable popup #522
Conversation
mauriciocolli
commented
May 1, 2017
- Resizable popup
- You can enter in resize-mode when you longpress one of the sides of the popup
- Remember/save the popup position and size
- Fix bug occurring after screen rotation
- Check if position is greater than the bounds of the (new sized) screen
Hm, I can't figure out how to resize the window. Also please remember to fix #517 it's important. |
Lol, did you read the message of the pull request? But nevertheless, this is a sign that this feature is not very user discoverable. But I think you should merge it, as it fixes a bug in the popup, and if something better comes to mind, I'll open another PR. |
Yea, no didn't reed you're right. All right. |
Will this be merged? |
Yes ... I'll alway try to merge and release on weekends, but I'm ill at the moment, and I'm almost not able to leave the bed. |
Oh okay, good recovering to you. |
thanks :) |
Although my opinion is still that two finger resize feels more swift, and is more intuitive. So maybe we can have both ;) |
@theScrabi Two finger resize is more intuitive, it was the first thing my mom tried. @mauriciocolli Btw when is the resizable popup coming to F-Droid's repo? My mom's tablet has a postage stamp sized video lol. |
@SteveJobzniak you can tell your mom next release is on its way ;). |
@theScrabi Thanks, she's happy from the news. :-) So, soon she can watch larger cat video popups while doing her puzzle games. xD |