Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resizable popup #522

Merged
merged 1 commit into from
May 7, 2017

Conversation

mauriciocolli
Copy link
Contributor

  • Resizable popup
    • You can enter in resize-mode when you longpress one of the sides of the popup
    • Remember/save the popup position and size
  • Fix bug occurring after screen rotation
    • Check if position is greater than the bounds of the (new sized) screen

@mauriciocolli mauriciocolli mentioned this pull request May 1, 2017
@theScrabi
Copy link
Member

theScrabi commented May 1, 2017

Hm, I can't figure out how to resize the window. Also please remember to fix #517 it's important.

@mauriciocolli
Copy link
Contributor Author

Lol, did you read the message of the pull request?

But nevertheless, this is a sign that this feature is not very user discoverable.
Maybe show a tip on the first use? Maybe other gesture? Idk...

But I think you should merge it, as it fixes a bug in the popup, and if something better comes to mind, I'll open another PR.

@theScrabi
Copy link
Member

theScrabi commented May 2, 2017

Yea, no didn't reed you're right.
I thought it was some kind of two finger gesture.

All right.

@mauriciocolli
Copy link
Contributor Author

Will this be merged?

@theScrabi
Copy link
Member

Yes ... I'll alway try to merge and release on weekends, but I'm ill at the moment, and I'm almost not able to leave the bed.

@mauriciocolli
Copy link
Contributor Author

mauriciocolli commented May 6, 2017

Oh okay, good recovering to you.

@theScrabi theScrabi merged commit 040d658 into TeamNewPipe:master May 7, 2017
@theScrabi
Copy link
Member

thanks :)

@theScrabi
Copy link
Member

Although my opinion is still that two finger resize feels more swift, and is more intuitive. So maybe we can have both ;)

@ghost
Copy link

ghost commented May 8, 2017

@theScrabi Two finger resize is more intuitive, it was the first thing my mom tried.

@mauriciocolli Btw when is the resizable popup coming to F-Droid's repo? My mom's tablet has a postage stamp sized video lol.

@theScrabi
Copy link
Member

@SteveJobzniak you can tell your mom next release is on its way ;).
We are basically waiting for f-droid to build the new release, which takes usually about two or three days. So since I released yesterday, it may be available on Thursday or Wednesday.

@ghost
Copy link

ghost commented May 8, 2017

@theScrabi Thanks, she's happy from the news. :-) So, soon she can watch larger cat video popups while doing her puzzle games. xD

@mauriciocolli mauriciocolli deleted the feature-resize branch May 14, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants