-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update most dependencies #4768
Update most dependencies #4768
Conversation
I'm on it. |
its a bit more complicated this time to upgrade ExoPlayer. We need to provide a MediaItem. And media2 is incompatible with the MediaButtonReceiver. I did not find any replacement for that yet (or don't know if this is even required). For now we could just try ExoPlayer and investigate media2 afterwards, but we still need that MediaItem. I wanted to take a look at ExoPlayer's internals for that, as it converts MediaItems back to MediaSources for playback. Therefore it should hopefully not be hard to also get it working the other way around so that we can return suitable data there. |
I tried everything I could think of and found no issues. |
Are we ready for this? Don't we need the SAF PR as a prerequisite for this? |
Oh, do we? I have no idea, maybe it's better if I revert that part and let somebody else change it with more knowledge about what changes |
49f1026
to
2c4befb
Compare
@opusforlife2 I reverted the change to the target sdk version |
Maybe RxJavaBridge could be used? That way an alpha version of Room wouldn't have to be used. |
@Isira-Seneviratne I think we are good using an alpha version of Room, since there are no open issues about the new RxJava3 support and there are no breaking changes regarding what we are already doing. Therefore I think using another library to achieve RxJava3 support, just to ditch it when upgrading Room to a stable 2.3 version, is not convenient ;-) |
2c4befb
to
18cb631
Compare
I fixed some ktlint errors arisen after rebase |
Hi! I tested the provided apk on Android Kitkat(api19) and found no bugs. |
@Stypox |
18cb631
to
987b6d4
Compare
I rebased after Java-8-date-time changes. I also enabled ktlint's autoformatting by default and used version |
It's been updated again to 1.1.1. |
Rebased and updated |
017a846
to
095ec30
Compare
Again: |
@TobiGr I think I tested this well enough, can it be merged before creating any new conflict? |
uh yeah. we should merge. Can you resolve the conflicts on more time, please? |
095ec30
to
79e0a77
Compare
I rebased again @TobiGr : |
Update checkstyle (8.36.2 -> 8.37) and mockito-core (3.5.13 -> 3.6.0): |
I checked manually every library we are using and they were all up to date except those two (which I updated). Since those library are not used by the code but only for testing purposes, there is no difference. |
557e8ab
to
a44f307
Compare
Ok, rebased again, hopefully the last one ;-) |
What is it?
Description of the changes in your PR
This is basically #4508 but also contains:
androidx.constraintlayout:constraintlayout
from2.0.2
to2.0.4
Other than that, it is identical to #4508 (by @wb9688, he told us we could continue his PRs):
androidx.documentfile:documentfile
andandroidx.localbroadcastmanager:localbroadcastmanager
were previously part of some other AndroidX library, whilecom.squareup.leakcanary:plumber-android
is a new feature from LeakCanary that fixes known memory leaks in the Android framework.Media2
(replacement forMediaSessionCompat
, which is now deprecated) support, and maybe toplevel playlist support. @Redirion: Do you want to do that in some PR? Also see Update most dependencies #4508 (comment)APK testing
I tested a little bit on 4.4 but didn't have much time for further testing. @Poolitzer @mhmdanas @mqus @MD77MD @opusforlife2 could you test this, if you have some time? You'd have to just go through the screens and the buttons the app has and verify nothing crashes.
app-debug.zip
Due diligence