Add Drawer Personalization

[werererer]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• seperate Drawer stuff from MainActivityClass
• customize Drawer/Panel

Fixes the following issue(s)

• personalize sidebar #4081

Test Apk

newpipeDrawerupdateApk.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

This is my first PR that had android studio involved. It incoporates a feature to Configure the left Panel/Drawer. This can be done under settings/Content/Content of main page.

I also seperated Drawerlogic from the main Activity class. The Drawerlogic is now in the DrawerFragment class.

[opusforlife2]

Maybe it should be under Appearance? Worth discussion, I think.

[werererer]

I think so since changing the drawer changes the Appearance

[TobiGr]

Thank you for your contribution @werererer!
Please update Gradle in a separate PR.
PS: you can tick checkboxes by using - [x] (no spaces between the brackets and the x)

[opusforlife2]

PS: you can tick checkboxes by using - [x] (no spaces between the brackets and the x)

Or, far easier, you can just tick the boxes by clicking on them after you've already created the post.

[werererer]

What do you mean with Gradle in a separate PR @TobiGr.
Sorry I am not really a Java main so I don't know what you meant with "Please update Gradle in a separate PR".
PS: thanks for the tipps :D

[wb9688]

Undo these changes

[opusforlife2]

Since you used Android Studio, you must have gotten that update prompt "Update Gradle Plugin". There is some stupid setting that Google introduced which automatically screws with your current projects, namely Newpipe. When you get that prompt, just close it. Or, now that you have updated already, just undo that change from the build.gradle file as wb9688 said.

[werererer]

Ok

[werererer]

Ok fixed it

[werererer]

Some tips for reviewing (as i didn't split up the pull request sry. After some research I know now that it should be done :/):

• a lot of functions moved from Mainactivity to Drawefragment
• thats why i delete that much there
• AddSectionDialog, ChooseSectionsFragment, Section, SectionsJsonHelper and SectionsManager have the exact same task as the Tab counterpart.
• except that they are for the drawer
• I copied a lot of the code from other classes infact and altert it then according to the need
• we may even let the sections and tabs classes extend the same interface/class (as they are so similar)

[MD77MD]

we may even let the sections and tabs classes extend the same interface/class (as they are so similar)

@werererer could you take a look at this:
#3825 Reorder and manage newPipe tabs from home screen 

while your working on this, I wish if customizing can be done directly from drawer, without the need to dig into settings.
from my point of view, newPipe is always expanding and adding new sources for content (YouTube, SoundCloud...). at the same time, adding more personalization options like this PR as well as functionalities like pinning channels & playlists to taps. with time customizing drawer and tabs for each service can become a hassle. each time a user needs to change something, the user is required to dig deep into settings.

In my opinion, the easiest way to solve this is by using pop-up menu (similarly to video pop-up menu). the menu should have all the function needed (remove, add, reorder...etc). similarly, the menu can be activated by long pressing on the item or tab you want to change.

If customization could be done this way, it would make personalization of all the services so much easier. I know this needs more effort from you but it's worth it.

newPipe deserves perfection 💖

[werererer]

good idea i will work on it later :)

[werererer]

I looked at it and i realized that this would require way more work than expected. I also don't really have the knowledge to implement this :/(it would require a new drawer and panel that has a recyclerview in it?). As for this PR it may be overkill :/

[wb9688]

I think just having it inside the settings is OK

[werererer]

ok I think everything works now I don't plan to make any greater changes in this PR (if I didn't introduce bugs)

[wb9688]

Could you rebase on dev and fix potential Checkstyle issues? I'll take a look at the UI and code later.

[werererer]

how do i rebase? (sry still relatively new to github)

[werererer]

nevermind working on it now

[wb9688]

Something like:

git remote add TeamNewPipe https://github.com/TeamNewPipe/NewPipe.git
git fetch TeamNewPipe
git rebase --interactive TeamNewPipe/dev

Then close the editor it opens. After that try building it again in Android Studio and you might get some (Checkstyle) errors that you need to fix.

Edit: you might need to do additional stuff in case of merge conflicts though. If it says "Could not apply", you have to run git status to check what files you need to manually merge and when you've manually merged them, git add those files and then git rebase --continue.

[werererer]

fixed it

[werererer]

is it correct that almost all variables have to be declared final now?

[wb9688]

@werererer: Yes, that's true and you could see on CI that you didn't do that. Also for the future: we prefer rebases over merges.

[werererer]

Ah sorry I messed up than :/. Fixed the checkstyle now

[wb9688]

Oh, no problem. At least CI is green now. I hope I'll be able to look at this PR soon.

[werererer]

My PR doesn't seem to be reviewed anymore :/. Should I split this PR up into multiple smaller ones so that it is easier to review? I am willing to do it if it raises the chance of getting this feature.

[werererer]

@litetex Ok just as an info I am currently working on it and I realized that roughly 30% of the code became too outdated. I will have to rewrite them manually so it may take a few days.

[werererer]

@litetex nevermind was easier than I though lol xD. It works now in my build I will clean now things up and make it ready to pull.

[werererer]

@litetex ok it's done :)

[litetex]

Okay I reviewed the PR and found a bunch of issues:

• There is documentation / comments missing on some key-classes/methods (e.g. https://github.com/TeamNewPipe/NewPipe/pull/4104/files#diff-6e999cc285df1003629c36815181e973e47fd00bb85c98782a0b42d1154d36c9R308 /

  NewPipe/app/src/main/java/org/schabi/newpipe/settings/drawer_items/ChooseDrawerItemsFragment.java

  Line 308 in 128354e

  final int minimumAbsVelocity = Math.max(12,

  )
• Logic is stretched all over the place and not isolated inside classes
  • e.g. DrawerItem (which is a container to hold an item) is not isolated and has logic from UI, persistence and services inside it
• I'm not happy with the package name, as it contains a "_"
• There are multiple typos
• Code is duplicated (e.g. DrawerItem#ITEM_ID...)
• Logging is missing on certain places / e.printStackTrace()
• The draweritems for the kiosk are in the settings multiple times?
• There is unused and commented out code in some places
• Persistence is done using one JSON string - I don't know if this is a good idea
• It's possible to add draweritems multiple times - I don't think that that is making sence (e.g. download)
• There are unused drawer items: BLANK, SETTING and ABOUT
• Finding the edit option for the menu is a bit un-intuitive, as it's hidden in the content settings

I think we have to rethink if we even want to add this in the first place because the corresponding issue has 4 upvotes in total...

People seem to mainly want a "distraction" or "addiction" free mode which I personally don't understand because simply uninstalling the app or don't using the phone is a way better approach.

[werererer]

@litetex Thanks for the review.

with most of your issues I agree and they are mostly a result of hastly written code..

Anyways I want to point out that my drawer_items code is mostly based on tab*.java code. I didn’t want to make another abstraction around it to avoid merge conflicts. So issues mentioned in the DrawerItem class may also appear in the Tab classes already existing in the code base and I dont know if I am able to resolve this issue quickly.

The reason drawer items exist multiple times in the config is because the number of kiosks is not defined and the default kiosks will be replaced with the given kiosks in order excluding all kiosks that the user specifically added himself(e.g. youtube trending). I didnt find a better way to configure it without having to write my own fragment for it.

That you can add downloads specifically multiple times is a bug I didnt found...

where would you put the configuration instead of putting it under content? I just put it near the configuration for the tabs.

To your last point about addiction. I think this app has great elements to cope with addiciton with youtube. You can toggle comments and recommendations. Stop watching youtube cold turkey is pretty hard/nearly impossible. Watching videos on newpipe though is an easier alternative as you can still watch certain youtubers that you really want to follow without getting distracted by unimportant content because of said features. (source personal experience)
So a year ago I thought about a feature to toggle kiosks as they also distracted me and tried to think of a more general feature.
Then I came up with configurable drawers...

Whether we still want to have this feature depends though It is not easy to maintain this code since I lost interest for it myself...

Anyways If we still want to have this feature I will fix mentioned issues.

[litetex]

I did some further discussion with our dev team (again) and we came to the conclusion, that we don't want to add this feature as it's a) only relevant to few people (marked the issue as niche) and b) that the code - in the current form - it's not maintainable by us (would probably introduce new problems, etc).

TL;DR
The cost-benefit factor is too low.

For now I will close the PR due to the above points. Anyway, thank you for the PR and everyone else for the work that went into this.

[werererer]

ok sounds reasonable

[a-kbd]

What a shame, thank you for the hard work though @werererer, I wish it would have become a reality