Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes enqueue resuming paused videos #3787

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Conversation

budde25
Copy link
Contributor

@budde25 budde25 commented Jun 18, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes an issue where having a paused video in the popup player then enqueuing another video would cause the paused video to start playing again.
  • Does not break expected behavior, clicking the popup button will still immediately play the video that it was clicked on.

Fixes the following issue(s)

Testing apk

debug.zip

Agreement

@budde25 budde25 changed the title fixes enqueue resuming paused videos Fixes enqueue resuming paused videos Jun 18, 2020
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same behaviour as in the background player, and everything works fine there. I tested the apk and now enqueueing on popup works as expected. Every other popup-related button works fine just like before. Thank you for the PR! :-D

Use closing keywords when pointing out a fixed issue, so that GitHub closes it automatically on merge. I edited the description.

@TobiGr TobiGr added this to the 0.19.6 milestone Jun 27, 2020
@TobiGr TobiGr added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Jun 27, 2020
@TobiGr TobiGr merged commit d910091 into TeamNewPipe:dev Jun 27, 2020
This was referenced Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup resume videos, after touching "enqueue in popup".
3 participants