Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Markdown export of crash logs #3579

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Add Markdown export of crash logs #3579

merged 1 commit into from
Jul 6, 2020

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented May 13, 2020 •
edited
Loading

Add content country as additional debug information to reports

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Adds button to error screen to copy markdown crash report and button to open our GitHub issue page.

Fixes the following issue(s)

Part of #1816

Testing apk

app-debug.apk.zip

Agreement

@TobiGr TobiGr force-pushed the error_md_export branch from 456d377 to 4846094 Compare May 13, 2020 08:08
@B0pol
Copy link
Member

B0pol commented May 13, 2020 •
edited
Loading

Can you send a screenshot / provide more info? Is it just Crash report to markdown but in-app?

@wb9688
Copy link
Contributor

wb9688 commented May 13, 2020

@B0pol: That's what it's supposed to be, yeah

B0pol
B0pol requested changes May 13, 2020
View reviewed changes
Copy link
Member

@B0pol B0pol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY

app/src/main/java/org/schabi/newpipe/report/ErrorActivity.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/report/ErrorActivity.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/report/ErrorActivity.java Show resolved Hide resolved
@TobiGr TobiGr force-pushed the error_md_export branch from 4846094 to fc05954 Compare May 13, 2020 18:09
@opusforlife2
Copy link
Collaborator

Awesome! I was considering opening an issue regarding the clunky method of going to the crash report to markdown converter every time. This is much better!

@wb9688 wb9688 added this to the 0.19.4 milestone May 16, 2020
@B0pol B0pol added the feature request Issue is related to a feature in the app label May 17, 2020
@Stypox Stypox modified the milestones: 0.19.4, 0.19.5 May 28, 2020
@ghost ghost mentioned this pull request May 31, 2020
Closed
@TobiGr TobiGr mentioned this pull request Jun 4, 2020
Merged
@TobiGr TobiGr force-pushed the error_md_export branch from fc05954 to 1700a2e Compare June 27, 2020 19:41
@TobiGr TobiGr requested a review from B0pol June 27, 2020 19:47
@TobiGr TobiGr force-pushed the error_md_export branch from 1700a2e to f437660 Compare June 27, 2020 19:50
B0pol
B0pol requested changes Jun 27, 2020
View reviewed changes
Copy link
Member

@B0pol B0pol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except that small thing I think it's ready for merge

app/src/main/java/org/schabi/newpipe/report/ErrorActivity.java Outdated Show resolved Hide resolved
@TobiGr TobiGr force-pushed the error_md_export branch from f437660 to f06f9e8 Compare June 27, 2020 22:44
@TobiGr
Add Markdown export of crash logs
3de5afc 
Add app language as additional debug information to reports
@TobiGr TobiGr force-pushed the error_md_export branch from f06f9e8 to 3de5afc Compare June 28, 2020 14:07
@TobiGr TobiGr mentioned this pull request Jul 5, 2020
Merged
@TobiGr TobiGr merged commit ff4e6b1 into TeamNewPipe:dev Jul 6, 2020
This was referenced Jul 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opusforlife2 opusforlife2 opusforlife2 left review comments

@B0pol B0pol B0pol requested changes

@wb9688 wb9688 wb9688 requested changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Milestone
0.19.6
Development

Successfully merging this pull request may close these issues.
5 participants
@TobiGr @B0pol @wb9688 @opusforlife2 @Stypox