Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of group sort button in the subscriptions fragment #3374

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

mauriciocolli
Copy link
Contributor

What is it?

  • Bug fix
  • Feature
  • Code base improvement
  • Meta improvement to the project

Description of the changes in your PR

The visibility of the group sort button in the subscriptions fragment was not the right one when a rebind happened (e.g. return from another fragment that destroyed its host's views).

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce the buggy behaviour with 0.19.2. However, code looks fine. I think this should be good to merge.

@TobiGr TobiGr added this to the 0.19.3 milestone Apr 6, 2020
@mauriciocolli mauriciocolli added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Apr 6, 2020
@mauriciocolli
Copy link
Contributor Author

@TobiGr: I cannot reproduce the buggy behaviour with 0.19.2.

The bug is definitely there, here's the steps to reproduce it:

  1. Have less than 2 groups.
  2. Scroll down (enough so the header item is not visible when you return to the screen).
  3. Go to another fragment, so the current one destroy its views (e.g. open a channel).
  4. Go back.

The update message is not processed by the item because it isn't visible when the check happens in the fragment, that message is also not replayed so it is essentially lost.

Holding its state in a variable fix that because when the item do a rebind (it is visible again), it will check it and find the correct value.

@TobiGr TobiGr merged commit 1600233 into TeamNewPipe:dev Apr 7, 2020
This was referenced Apr 24, 2020
@mauriciocolli mauriciocolli deleted the fix-sort-button-visibility branch December 8, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants