Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DownloaderImpl in CheckForNewAppVersionTask #3344

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Use DownloaderImpl in CheckForNewAppVersionTask #3344

merged 2 commits into from
Apr 4, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Apr 3, 2020

This way we only have to change code in DownloadImpl and the ExoPlayer stuff when we want to add support for e.g. setting a SOCKS proxy in the settings. I tested that this works successfully.

@TobiGr
Copy link
Contributor

TobiGr commented Apr 3, 2020

Could you also reduce this to one case:

} catch (NoSuchAlgorithmException ex1) {
ErrorActivity.reportError(APP, ex1, null, null,
ErrorActivity.ErrorInfo.make(UserAction.SOMETHING_ELSE, "none",
"Could not retrieve SHA1 key", R.string.app_ui_crash));
} catch (CertificateEncodingException ex2) {
ErrorActivity.reportError(APP, ex2, null, null,
ErrorActivity.ErrorInfo.make(UserAction.SOMETHING_ELSE, "none",
"Could not retrieve SHA1 key", R.string.app_ui_crash));
}

        } catch (NoSuchAlgorithmException | CertificateEncodingException ex) {
            ErrorActivity.reportError(APP, ex, null, null,
                    ErrorActivity.ErrorInfo.make(UserAction.SOMETHING_ELSE, "none",
                            "Could not retrieve SHA1 key", R.string.app_ui_crash));
        }

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

@wb9688 wb9688 requested a review from TobiGr April 4, 2020 18:05
@TobiGr TobiGr merged commit 5653d44 into TeamNewPipe:dev Apr 4, 2020
This was referenced Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants