Fix mute button causing crashes on API 19 #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using rootView.getContext() because getApplicationContext() didn't work (it was probably missing information about theme)
Stypox
added
ASAP
|
I have test this apk and problem is fix, thanks. |
|
It didn't crash! |
TobiGr
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Long description of the changes in your PR
Fixes crashes when instantiating the background and popup queues, due to a problem in obtaining and setting the drawable to the menu icon on API 19.
Note: using rootView.getContext() because getApplicationContext() didn't work (it was probably missing information about theme)
Fixes the following issue(s)
Testing apk
I tested this fix on Android 4.4 (API 19, emulator) and Android 7.1 (phone). @Anotherlife could you test this apk?
app-debug.zip
Agreement