-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mute button inflation problems on API<21 #3283
Conversation
@domiuns thanks for the report in #3266. Could you please test if this debug apk fixes your issue? Off-topic: sono anch'io italiano ;-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, did you test this in a API 19 emulator?
Anyway, that's not the issue as srcCompat
is correctly used in the layout, the issue is that ContextCompat
is being used to fetch a vector drawable, which isn't the intended use for it.
AppCompatResources
is the correct one.
I did not, as I have a slow internet connection and no time to download a whole emulator.
Could you do that, please? I don't know how and where I should use AppCompatResources :-/ |
@mauriciocolli is correct. You need to change it here:
Already tested in the emulator. Works 👍 |
@Stypox i have test your apk i have this Exception
Crash log
|
edfaee2
to
a83000b
Compare
a83000b
to
f9b718f
Compare
Ok, I will download it, for some reason I remember seeing multiple GB of download a while ago, but who knows what I saw ;-) |
See https://stackoverflow.com/questions/35819290/invalid-drawable-tag-vector
There was no need to change other ImageButtons because the image was set programmatically only in the mute button