-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.19.0 #3267
Merged
Merged
Release 0.19.0 #3267
Changes from all commits
Commits
Show all changes
238 commits
Select commit
Hold shift + click to select a range
cf377c2
Fix bug causing crashes when sharing a downloaded file.
XiangRongLin 91bd0be
Spelling: Some devices are incompatible
comradekingu 01dcf55
Update issue templates
Poolitzer e8f28eb
Merge branch 'templates' of https://github.com/Poolitzer/NewPipe into…
Poolitzer 495b495
deleting old template
Poolitzer 30f66d0
Update PULL_REQUEST_TEMPLATE.md
Poolitzer a3bce7f
Change app id based on current git branch
Stypox d46cd26
Merge branch 'dev' into gradle-app-id-suffix
Stypox 030e5ab
Add comment to gradle
Stypox 3434ff4
Merge branch 'gradle-app-id-suffix' of github.com:Stypox/NewPipe into…
Stypox dc6a0e3
mute-button added to activity_main_player.xml's
kaminski-karol 4415888
mute-button implementation in main player
kaminski-karol cc559dc
isMuted() added
kaminski-karol 2a63f2a
mute-buton in queue layout and logic, but no icon change
kaminski-karol c4d5886
icon change implemented in queque
kaminski-karol 01c1fa0
B0pol suggested improvements
Poolitzer 1d9ffff
Minor improvements
Poolitzer d9a8e4d
NewPipe is an app though :(
Poolitzer 40f54ae
mute intent send between main-bckgrnd-popup players
kaminski-karol 0400fcb
mute icon in main refactored
kaminski-karol 46165f4
adding version section to bug report
Poolitzer e2cb927
Merge branch 'templates' of https://github.com/Poolitzer/NewPipe into…
Poolitzer ee75909
set mute button in main player from other player
kaminski-karol a6fcb70
fix typo
kaminski-karol 5257c5a
Translated using Weblate (Esperanto)
B0pol deafe93
Translated using Weblate (Russian)
ca2e9d4
Translated using Weblate (French)
B0pol 7e2bec8
Merge branch 'origin/dev' into Weblate.
weblate 5d7eba3
Merge remote-tracking branch 'upstream/dev' into templates
Poolitzer add08ea
Accept music.youtube.com in manifest
wb9688 e7063b2
Translated using Weblate (Indonesian)
667a524
Translated using Weblate (Indonesian)
danipragustia 92f4010
Add more checks to prevent build failures in gradle branch suffix
Stypox 92ee51b
resolved issues
kaminski-karol 07d1faf
Links support for mediaccc and shortened invidious
B0pol 1243401
remove redundant code
B0pol c79f09c
mute button in actionbar, no color change
kaminski-karol 840bb29
icon color change in action bar
kaminski-karol afebd9b
improvements
Poolitzer 08dffad
opus4improvements
Poolitzer d265382
missed this
Poolitzer 3f118a7
appending dots
Poolitzer 57504ac
If inexact seekt is used, hide 5,15,25 seconds seek duration options …
XiangRongLin 4463804
Update seek options on inexact seek option change.
XiangRongLin 288a618
Update inexact seek summary
XiangRongLin 6a42714
Round seek duration up instead of setting it to 10 seconds
XiangRongLin 7d3b215
Use DateUtils constant for 1000
XiangRongLin e3fff43
Show a toast when seek duration was rounded up
XiangRongLin efb67b0
Change toast string resource to be useable with different languages
XiangRongLin 0a87f13
Merge pull request #3107 from comradekingu/patch-11
Stypox f7ef7a1
Update app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettin…
XiangRongLin 4bb6a14
Update app/src/main/res/values/strings.xml
Stypox d5c29bf
Merge pull request #3160 from XiangRongLin/b3127
Stypox 9b65b00
Translated using Weblate (Indonesian)
danipragustia e421d47
Translated using Weblate (Indonesian)
e1fb883
Translated using Weblate (Japanese)
AioiLight 6962882
Translated using Weblate (Italian)
silkevicious ebdf488
Translated using Weblate (Arabic)
m0hdx 371280f
Translated using Weblate (Indonesian)
5c559e4
Translated using Weblate (Swedish)
iah 4cd9e0f
Merge branch 'origin/dev' into Weblate.
weblate 7da1120
Relocate two settings from Appearance to Content
opusforlife2 1ae8a72
mute icon change in action bar
kaminski-karol 83c7c4a
mute/unmute text change in action bar
kaminski-karol 2ca580d
minor improvements of sentences
Poolitzer 4e37a76
Further minor improvements
Poolitzer 55d7be0
null risk issue
kaminski-karol ecb1b45
Fix visual glitch when exiting the app
mauriciocolli c6b062a
checkpoint db before export
yausername 3e1e07e
refactor checkpointing
yausername 9db2197
Improve code style
TobiGr 029758f
Merge pull request #3046 from XiangRongLin/shareDownload
Stypox 8fa29ff
Merge pull request #3165 from karkaminski/mute_button
Stypox f2526ed
Fix bug in main screen tabs state management
mauriciocolli 64c289c
Merge pull request #3184 from opusforlife2/relocate_settings
Stypox cb2cb2e
Translated using Weblate (Turkish)
emintufan 5c5f4ad
Translated using Weblate (German)
nautilusx 225d7dc
Translated using Weblate (Basque)
osoitz b0c6317
Translated using Weblate (Czech)
auzkok 8e779c9
Translated using Weblate (Czech)
Krysaczek 583451e
Translated using Weblate (Croatian)
milotype b61c8d5
Translated using Weblate (Hebrew)
yarons 51e3905
Translated using Weblate (Polish)
454efa5
Translated using Weblate (Italian)
silkevicious 8143783
Translated using Weblate (Indonesian)
6ef75b3
Translated using Weblate (French)
VeryTastyTomato ed5e99c
Translated using Weblate (Chinese (Traditional))
s8321414 9c0d44e
Translated using Weblate (Chinese (Simplified))
bc6ecd4
Merge branch 'origin/dev' into Weblate.
weblate d1b1b77
Translated using Weblate (Russian)
158cd83
Translated using Weblate (Russian)
undeadfox 73e14af
Translated using Weblate (Russian)
undeadfox 33475ef
Merge pull request #3197 from mauriciocolli/fix-main-tabs
TobiGr c09e833
Translated using Weblate (French)
Floflr b43bc7f
Translated using Weblate (Portuguese (Brazil))
edcaron d0a5f75
Translated using Weblate (Portuguese (Brazil))
weblate f895e22
Translated using Weblate (German)
nautilusx afcda37
Translated using Weblate (Ukrainian)
burunduk a0823b2
Translated using Weblate (Asturian)
enolp dcdabe4
Translated using Weblate (Japanese)
AioiLight 17c140c
Translated using Weblate (Czech)
zeritti 6cdf97d
Translated using Weblate (Hebrew)
yarons 0a32314
Translated using Weblate (Polish)
04c7a66
Translated using Weblate (Italian)
8806981
Translated using Weblate (Interlingua)
softinterlingua 3265cdc
Translated using Weblate (Spanish)
j9o1 ead22fa
Translated using Weblate (French)
weblate c296634
Translated using Weblate (Chinese (Traditional))
s8321414 d2403d1
Translated using Weblate (Chinese (Simplified))
29edb8c
Merge branch 'origin/dev' into Weblate.
weblate f7822a4
Merge pull request #3133 from Stypox/gradle-app-id-suffix
TobiGr ca8f8e0
misc changes
kapodamy 1f42491
Translated using Weblate (Russian)
c35b13b
Merge branch 'origin/dev' into Weblate.
weblate 95f0e60
fix captions overtaking mute button
B0pol 0ee7876
Merge pull request #3224 from B0pol/buttons_player
TobiGr c668620
Merge pull request #3196 from mauriciocolli/fix-app-glitch
TobiGr 9f91043
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr d23b63c
Merge pull request #3177 from wb9688/yt-music
TobiGr 2001214
Fix seek duration not showing
B0pol c2535d7
Merge pull request #3195 from B0pol/second
TobiGr 89e3292
Move code with lower priority to the bottom of the file
mauriciocolli d247d32
Change share title as well to differentiate multiple builds
mauriciocolli 0e2f062
Disable database destructive migration fallback
mauriciocolli e8ab5aa
Setup initial database for feed implementation
mauriciocolli 20a4bb0
Implement new feed and subscriptions groups
mauriciocolli f69b6c8
Fix alignment issues in group creator dialog
mauriciocolli a93e2cd
Quick fix for NPE when exiting the feed fragment
mauriciocolli 8b87893
Update Groupie list library to v2.7.0
mauriciocolli f05b8c9
Expand import/export options by default when subscriptions list is empty
mauriciocolli 2948e41
Change feed groups header title and icon from feed representing "All"
mauriciocolli b2f317a
Load only the selected group and customizable updated status timeout
mauriciocolli 5ea323c
New option to use dedicated feed sources for services that support it
mauriciocolli 3f32573
Replace hardcoded value that represents the group "All" with a constant
mauriciocolli 2c783ff
Stick info header when selecting subscriptions in the feed group dialog
mauriciocolli 18a4016
Add Groupie library to the credit list in the about page
mauriciocolli 50714c3
Add ability to cancel a feed update through a notification action
mauriciocolli d1d5f68
Implement feed groups manual sorting
mauriciocolli 34082c4
Fix behavior of the feed group dialog under some screen sizes/scales
mauriciocolli 597859e
Disable buttons when processing actions in the feed dialogs
mauriciocolli 98c65d8
Don't expose MutableLiveData in view models
mauriciocolli d8b9d35
Add a confirmation dialog when deleting a feed group
mauriciocolli f01e40e
Simplify screen handling in feed group dialog
mauriciocolli b62142d
Detect if the subscription list should be shown as a grid
mauriciocolli ac44ed0
Localize duration strings used in feed settings using plurals
mauriciocolli 6a9a0f1
Add tests for migrations in the Room database
mauriciocolli a4babc1
Merge pull request #3225 from mauriciocolli/improve-build-branch
TobiGr 97f5490
Add help dialog to feed screen
mauriciocolli f8cc318
Merge pull request #2309 from mauriciocolli/feed
TobiGr 878a5db
Translated using Weblate (German)
nautilusx dc1312d
Translated using Weblate (Esperanto)
B0pol 0486ccb
Translated using Weblate (Macedonian)
fcc8066
Translated using Weblate (Polish)
weblate 0876cdd
Translated using Weblate (Interlingua)
softinterlingua 373ec96
Translated using Weblate (Nepali)
hemanta212 eacd21b
update extractor version
B0pol c4a601b
Merge pull request #3090 from B0pol/mediaccc
TobiGr 0ab4b6d
Delete subscription_header.xml
Stypox be5654d
Merge pull request #3233 from TeamNewPipe/delete-subscription-header
wb9688 df2a383
Revert manifest removal from build variant
mauriciocolli 0f96f3b
Translated using Weblate (Nepali)
hemanta212 ce15697
Merge pull request #3234 from mauriciocolli/revert-manifest-removal
TobiGr 436b08a
Translated using Weblate (Nepali)
hemanta212 e83e755
dropping markdown links in comments
Poolitzer 02ef0b0
a document is not nice
Poolitzer b1c72ba
Merge remote-tracking branch 'weblate/dev'
mauriciocolli d0f2a02
delete «seconds» plural string in favor of «dynamic_seek_duration_des…
B0pol 0ae4d13
use plural string for feed_group_dialog_selection_count
B0pol 85e16af
use val instead of val, make sentence more natural
B0pol 27fc0d5
Make duration plurals naming consistent
mauriciocolli fb3290e
Merge pull request #3230 from B0pol/seconds
mauriciocolli 49c6aa2
Update .github/ISSUE_TEMPLATE/feature_request.md
TobiGr 4d4fb9f
Merge branch 'master' into dev
TobiGr b4a5f29
Translated using Weblate (German)
nautilusx 8b45256
Translated using Weblate (Hebrew)
yarons 565a5ab
Translated using Weblate (Indonesian)
zmni ac9057b
Translated using Weblate (Slovak)
marulinko 60bcd70
Translated using Weblate (Norwegian Bokmål)
comradekingu 37f4469
Merge branch 'origin/dev' into Weblate.
weblate cab104a
Merge pull request #3132 from Poolitzer/templates
TobiGr 50fd10e
Remove titles from issue templates and fix typo
TobiGr 27156d7
Merge pull request #3220 from kapodamy/webm-seek-fix
TobiGr 0a412e2
Remove search icon in search mode. Issue: #3183 (see PR #3193)
jonas-skywalker 47c5008
Change mute button color for more visibility
B0pol c54ac32
mute button color for queue
B0pol 8d068b3
remove unused imports
B0pol bb91b16
use 8F instead of 6f for white hexadecimal, on @wb9688 advise
B0pol 3e348f8
Translated using Weblate (German)
nautilusx a86912c
Translated using Weblate (Nepali)
hemanta212 b31fbc3
Translated using Weblate (Spanish)
j9o1 ebb1389
Translated using Weblate (French)
B0pol a433e5b
Translated using Weblate (Chinese (Traditional))
s8321414 da5369e
Merge branch 'origin/dev' into Weblate.
weblate 5a8b565
Merge pull request #3252 from B0pol/mute_button
TobiGr 4524a69
Update extractor version
TobiGr 3290478
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr 6eeb229
Fix what Weblate screwed up again
TobiGr 6ac52f2
Do not show nothing for some quantities for Chinese
TobiGr 60252bb
Remove unused "playback_default" string
TobiGr a19be79
Remove unused "clear_finished_download" string
TobiGr 5f940c4
fix integer overflow
kapodamy 452f258
Merge pull request #3273 from kapodamy/int-overflow-fix
TobiGr 93b75b6
Update extractor version
TobiGr 55c577e
Seek duration should not be rounded up when opening the settings, eve…
TobiGr c6de6e5
Translated using Weblate (Portuguese (Brazil))
2e3f240
Translated using Weblate (Turkish)
emintufan 838f8cb
Translated using Weblate (Portuguese (Brazil))
weblate 8168445
Translated using Weblate (German)
nautilusx 1994dad
Translated using Weblate (German)
franconian 89dc5ce
Translated using Weblate (Esperanto)
B0pol 782b983
Translated using Weblate (Asturian)
enolp 6e3170f
Translated using Weblate (Japanese)
AioiLight c4f58cb
Translated using Weblate (Czech)
zeritti aef673a
Translated using Weblate (Croatian)
Stipess1 39bb0f4
Translated using Weblate (Croatian)
weblate 4cd5afa
Translated using Weblate (Hebrew)
yarons c687d83
Translated using Weblate (Italian)
pjammo 4d23cf7
Translated using Weblate (Dutch)
wb9688 082b7fa
Translated using Weblate (French)
B0pol 5447518
Translated using Weblate (Kurdish)
ShexSMohammed 9a980f9
Translated using Weblate (Chinese (Simplified))
aa87f10
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr 6ce338b
Weblate ...
TobiGr c6eaed7
Translation fixes
TobiGr d8e83da
Temporary: Fix menu visibility when restoring state in the pager adapter
mauriciocolli bbd8751
Merge pull request #3281 from mauriciocolli/fix-main-screen-menu-crea…
TobiGr f133bbf
Introduce a proper way to find urls in a string input
mauriciocolli 4dc2898
Fix bug when searching for urls from shared content
mauriciocolli d051df9
Merge pull request #3278 from mauriciocolli/fix-url-parsing-share
TobiGr f9b718f
Use correct class for getting a vector drawable in older APIs
mauriciocolli 40de014
Merge pull request #3283 from Stypox/fix-mute-button
TobiGr b4cabe2
Handle content not available exception more comprehensively
mauriciocolli 7c72f17
Merge pull request #3279 from mauriciocolli/fix-not-found-handling
TobiGr 949150f
Update extractor version
TobiGr 3c3848d
Fix UI crash in Settings, Content (chinese language)
vlt23 505a689
Merge pull request #3292 from vlt23/dev
TobiGr bcd7703
Add changelog
TobiGr 7f21975
release version 0.19.0 (900)
TobiGr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
--- | ||
name: Bug report | ||
about: Create a bug report to help us improve | ||
labels: bug | ||
assignees: '' | ||
|
||
--- | ||
|
||
<!-- | ||
Oh no, a bug! It happens. Thanks for reporting an issue with NewPipe. | ||
|
||
Use this template to notify us if you found a bug. | ||
|
||
To make it easier for us to help you please enter detailed information below. | ||
|
||
Please note, we only support the latest version of NewPipe and the master branch. Make sure you have that version installed. If you don't, upgrade & reproduce the problem before opening the issue. The release page (https://github.com/TeamNewPipe/NewPipe/releases/latest) is the go-to place to get this version. In order to check your app version, open the left drawer and click on "About". | ||
|
||
P.S.: Our contribution guidelines might be a nice document to read before you fill out the report :) You can find it at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md | ||
--> | ||
### Version | ||
<!-- Which version are you using? --> | ||
- | ||
|
||
|
||
### Steps to reproduce the bug | ||
<!-- If you can't reproduce it, please try to give as many details as possible on how you think you got to the bug. --> | ||
Steps to reproduce the behavior: | ||
1. Go to '...' | ||
2. Press on '....' | ||
3. Swipe down to '....' | ||
|
||
### Expected behavior | ||
Tell us what you expected to happen. | ||
|
||
### Actual behaviour | ||
Tell us what happens instead. | ||
|
||
### Screenshots/Screen records | ||
If applicable, add screenshots or a screen recording to help explain your problem. GitHub should support uploading them directly in the issue field. If your file is too big, feel free to paste a link from an image/video hoster here instead. | ||
|
||
### Logs | ||
If your bug includes a crash, please head over to the [incredible bugreport to markdown converter](https://teamnewpipe.github.io/CrashReportToMarkdown/). Copy the result. Paste it here: | ||
|
||
<!-- That's right, here! --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
labels: enhancement | ||
assignees: '' | ||
|
||
--- | ||
<!-- Hey. Our contribution guidelines (https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md) might be an appropriate | ||
document to read before you fill out the request :) --> | ||
#### Is your feature request related to a problem? Please describe it | ||
A clear and concise description of what the problem is. | ||
Example: *I want to do X, but there is no way to do it.* | ||
|
||
#### Describe the solution you'd like | ||
A clear and concise description of what you want to happen. | ||
Example: *I think it would be nice if you add feature Y which makes X possible.* | ||
|
||
#### (Optional) Describe alternatives you've considered | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
Example: *I considered Z, but that didn't turn out to be a good idea because...* | ||
|
||
#### Additional context | ||
Add any other context or screenshots about the feature request here. | ||
Example: *Here's a photo of my cat!* | ||
|
||
#### How will you/everyone benefit from this feature? | ||
Convince us! How does it change your NewPipe experience and/or your life? | ||
The better this paragraph is, the more likely a developer will think about working on it. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,26 @@ | ||
<!-- Hey there. Thank you so much for improving NewPipe. Please take a moment to fill out the following suggestion on how to structure this PR description. Having roughly the same layout helps everyone considerably :)--> | ||
|
||
#### What is it? | ||
- [ ] Bug fix | ||
- [ ] Feature | ||
|
||
#### Long description of the changes in your PR | ||
<!-- While bullet points are the norm in this section, feel free to write a text instead if you can't fit it in a list --> | ||
- record videos | ||
- create clones | ||
- take over the world | ||
|
||
#### Fixes the following issue(s) | ||
<!-- Also add reddit or other links which are relevant to your change. --> | ||
- | ||
|
||
#### Relies on the following changes | ||
<!-- Delete this if it doesn't apply to you. --> | ||
- | ||
|
||
#### Testing apk | ||
<!-- Ensure that you have your changes on a new branch which has a meaningful name. This name will be used as a suffix for the app ID to allow installing and testing multiple versions of NewPipe. Do NOT name your branches like "patch-0" and "feature-1". For example, if your PR implements a bug fix for comments, an appropriate branch name would be "commentfix". --> | ||
debug.zip | ||
|
||
#### Agreement | ||
- [ ] I carefully read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md) and agree to them. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why increase by 30? It was a coincidence that e.g. 0.18.7 was 870 and it should just be increased by 10 like always imho. However now it's already too late.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though? It's nice to be consistent. In fact, I would prefer 1910 for 0.19.1 and eventually, 10000 for 1.0.0. It's just symbolic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I agree with opus.
I think we can do this when going 1.0.0 which should be soon after #2907 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-paste of my argument on IRC:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much easier and foreseeable IMO to just increase by the ever same amount. The interval of 10 isn't even really needed any more, but we should keep it. As @wb9688 showed, any "binding" to a version code doesn't work, there's always cases in which it breaks. A version code is 3 integers, not 1.