Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.0 #3267

Merged
merged 238 commits into from
Mar 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
238 commits
Select commit Hold shift + click to select a range
cf377c2
Fix bug causing crashes when sharing a downloaded file.
XiangRongLin Feb 3, 2020
91bd0be
Spelling: Some devices are incompatible
comradekingu Feb 17, 2020
01dcf55
Update issue templates
Poolitzer Feb 23, 2020
e8f28eb
Merge branch 'templates' of https://github.com/Poolitzer/NewPipe into…
Poolitzer Feb 23, 2020
495b495
deleting old template
Poolitzer Feb 23, 2020
30f66d0
Update PULL_REQUEST_TEMPLATE.md
Poolitzer Feb 23, 2020
a3bce7f
Change app id based on current git branch
Stypox Feb 23, 2020
d46cd26
Merge branch 'dev' into gradle-app-id-suffix
Stypox Feb 23, 2020
030e5ab
Add comment to gradle
Stypox Feb 23, 2020
3434ff4
Merge branch 'gradle-app-id-suffix' of github.com:Stypox/NewPipe into…
Stypox Feb 23, 2020
dc6a0e3
mute-button added to activity_main_player.xml's
kaminski-karol Feb 23, 2020
4415888
mute-button implementation in main player
kaminski-karol Feb 23, 2020
cc559dc
isMuted() added
kaminski-karol Feb 23, 2020
2a63f2a
mute-buton in queue layout and logic, but no icon change
kaminski-karol Feb 23, 2020
c4d5886
icon change implemented in queque
kaminski-karol Feb 23, 2020
01c1fa0
B0pol suggested improvements
Poolitzer Feb 24, 2020
1d9ffff
Minor improvements
Poolitzer Feb 24, 2020
d9a8e4d
NewPipe is an app though :(
Poolitzer Feb 27, 2020
40f54ae
mute intent send between main-bckgrnd-popup players
kaminski-karol Feb 27, 2020
0400fcb
mute icon in main refactored
kaminski-karol Feb 27, 2020
46165f4
adding version section to bug report
Poolitzer Feb 28, 2020
e2cb927
Merge branch 'templates' of https://github.com/Poolitzer/NewPipe into…
Poolitzer Feb 28, 2020
ee75909
set mute button in main player from other player
kaminski-karol Mar 1, 2020
a6fcb70
fix typo
kaminski-karol Mar 1, 2020
5257c5a
Translated using Weblate (Esperanto)
B0pol Feb 29, 2020
deafe93
Translated using Weblate (Russian)
Feb 29, 2020
ca2e9d4
Translated using Weblate (French)
B0pol Feb 29, 2020
7e2bec8
Merge branch 'origin/dev' into Weblate.
weblate Mar 1, 2020
5d7eba3
Merge remote-tracking branch 'upstream/dev' into templates
Poolitzer Mar 1, 2020
add08ea
Accept music.youtube.com in manifest
wb9688 Mar 2, 2020
e7063b2
Translated using Weblate (Indonesian)
Mar 2, 2020
667a524
Translated using Weblate (Indonesian)
danipragustia Mar 2, 2020
92f4010
Add more checks to prevent build failures in gradle branch suffix
Stypox Mar 2, 2020
92ee51b
resolved issues
kaminski-karol Mar 2, 2020
07d1faf
Links support for mediaccc and shortened invidious
B0pol Feb 12, 2020
1243401
remove redundant code
B0pol Feb 12, 2020
c79f09c
mute button in actionbar, no color change
kaminski-karol Mar 2, 2020
840bb29
icon color change in action bar
kaminski-karol Mar 2, 2020
afebd9b
improvements
Poolitzer Mar 3, 2020
08dffad
opus4improvements
Poolitzer Mar 3, 2020
d265382
missed this
Poolitzer Mar 3, 2020
3f118a7
appending dots
Poolitzer Mar 3, 2020
57504ac
If inexact seekt is used, hide 5,15,25 seconds seek duration options …
XiangRongLin Feb 29, 2020
4463804
Update seek options on inexact seek option change.
XiangRongLin Feb 29, 2020
288a618
Update inexact seek summary
XiangRongLin Feb 29, 2020
6a42714
Round seek duration up instead of setting it to 10 seconds
XiangRongLin Mar 2, 2020
7d3b215
Use DateUtils constant for 1000
XiangRongLin Mar 2, 2020
e3fff43
Show a toast when seek duration was rounded up
XiangRongLin Mar 2, 2020
efb67b0
Change toast string resource to be useable with different languages
XiangRongLin Mar 3, 2020
0a87f13
Merge pull request #3107 from comradekingu/patch-11
Stypox Mar 3, 2020
f7ef7a1
Update app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettin…
XiangRongLin Mar 3, 2020
4bb6a14
Update app/src/main/res/values/strings.xml
Stypox Mar 3, 2020
d5c29bf
Merge pull request #3160 from XiangRongLin/b3127
Stypox Mar 3, 2020
9b65b00
Translated using Weblate (Indonesian)
danipragustia Mar 2, 2020
e421d47
Translated using Weblate (Indonesian)
Mar 4, 2020
e1fb883
Translated using Weblate (Japanese)
AioiLight Mar 3, 2020
6962882
Translated using Weblate (Italian)
silkevicious Mar 3, 2020
ebdf488
Translated using Weblate (Arabic)
m0hdx Mar 3, 2020
371280f
Translated using Weblate (Indonesian)
Mar 4, 2020
5c559e4
Translated using Weblate (Swedish)
iah Mar 4, 2020
4cd9e0f
Merge branch 'origin/dev' into Weblate.
weblate Mar 4, 2020
7da1120
Relocate two settings from Appearance to Content
opusforlife2 Mar 4, 2020
1ae8a72
mute icon change in action bar
kaminski-karol Mar 4, 2020
83c7c4a
mute/unmute text change in action bar
kaminski-karol Mar 4, 2020
2ca580d
minor improvements of sentences
Poolitzer Mar 5, 2020
4e37a76
Further minor improvements
Poolitzer Mar 5, 2020
55d7be0
null risk issue
kaminski-karol Mar 5, 2020
ecb1b45
Fix visual glitch when exiting the app
mauriciocolli Mar 7, 2020
c6b062a
checkpoint db before export
yausername Feb 21, 2020
3e1e07e
refactor checkpointing
yausername Feb 21, 2020
9db2197
Improve code style
TobiGr Mar 7, 2020
029758f
Merge pull request #3046 from XiangRongLin/shareDownload
Stypox Mar 8, 2020
8fa29ff
Merge pull request #3165 from karkaminski/mute_button
Stypox Mar 8, 2020
f2526ed
Fix bug in main screen tabs state management
mauriciocolli Mar 8, 2020
64c289c
Merge pull request #3184 from opusforlife2/relocate_settings
Stypox Mar 8, 2020
cb2cb2e
Translated using Weblate (Turkish)
emintufan Mar 7, 2020
5c5f4ad
Translated using Weblate (German)
nautilusx Mar 5, 2020
225d7dc
Translated using Weblate (Basque)
osoitz Mar 6, 2020
b0c6317
Translated using Weblate (Czech)
auzkok Mar 4, 2020
8e779c9
Translated using Weblate (Czech)
Krysaczek Mar 6, 2020
583451e
Translated using Weblate (Croatian)
milotype Mar 4, 2020
b61c8d5
Translated using Weblate (Hebrew)
yarons Mar 4, 2020
51e3905
Translated using Weblate (Polish)
Mar 6, 2020
454efa5
Translated using Weblate (Italian)
silkevicious Mar 4, 2020
8143783
Translated using Weblate (Indonesian)
Mar 4, 2020
6ef75b3
Translated using Weblate (French)
VeryTastyTomato Mar 7, 2020
ed5e99c
Translated using Weblate (Chinese (Traditional))
s8321414 Mar 5, 2020
9c0d44e
Translated using Weblate (Chinese (Simplified))
Mar 6, 2020
bc6ecd4
Merge branch 'origin/dev' into Weblate.
weblate Mar 8, 2020
d1b1b77
Translated using Weblate (Russian)
Mar 11, 2020
158cd83
Translated using Weblate (Russian)
undeadfox Mar 11, 2020
73e14af
Translated using Weblate (Russian)
undeadfox Mar 11, 2020
33475ef
Merge pull request #3197 from mauriciocolli/fix-main-tabs
TobiGr Mar 11, 2020
c09e833
Translated using Weblate (French)
Floflr Mar 11, 2020
b43bc7f
Translated using Weblate (Portuguese (Brazil))
edcaron Mar 10, 2020
d0a5f75
Translated using Weblate (Portuguese (Brazil))
weblate Mar 10, 2020
f895e22
Translated using Weblate (German)
nautilusx Mar 8, 2020
afcda37
Translated using Weblate (Ukrainian)
burunduk Mar 10, 2020
a0823b2
Translated using Weblate (Asturian)
enolp Mar 9, 2020
dcdabe4
Translated using Weblate (Japanese)
AioiLight Mar 8, 2020
17c140c
Translated using Weblate (Czech)
zeritti Mar 11, 2020
6cdf97d
Translated using Weblate (Hebrew)
yarons Mar 8, 2020
0a32314
Translated using Weblate (Polish)
Mar 9, 2020
04c7a66
Translated using Weblate (Italian)
Mar 9, 2020
8806981
Translated using Weblate (Interlingua)
softinterlingua Mar 9, 2020
3265cdc
Translated using Weblate (Spanish)
j9o1 Mar 9, 2020
ead22fa
Translated using Weblate (French)
weblate Mar 11, 2020
c296634
Translated using Weblate (Chinese (Traditional))
s8321414 Mar 9, 2020
d2403d1
Translated using Weblate (Chinese (Simplified))
Mar 9, 2020
29edb8c
Merge branch 'origin/dev' into Weblate.
weblate Mar 11, 2020
f7822a4
Merge pull request #3133 from Stypox/gradle-app-id-suffix
TobiGr Mar 11, 2020
ca8f8e0
misc changes
kapodamy Mar 12, 2020
1f42491
Translated using Weblate (Russian)
Mar 12, 2020
c35b13b
Merge branch 'origin/dev' into Weblate.
weblate Mar 12, 2020
95f0e60
fix captions overtaking mute button
B0pol Mar 13, 2020
0ee7876
Merge pull request #3224 from B0pol/buttons_player
TobiGr Mar 13, 2020
c668620
Merge pull request #3196 from mauriciocolli/fix-app-glitch
TobiGr Mar 13, 2020
9f91043
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr Mar 13, 2020
d23b63c
Merge pull request #3177 from wb9688/yt-music
TobiGr Mar 13, 2020
2001214
Fix seek duration not showing
B0pol Mar 7, 2020
c2535d7
Merge pull request #3195 from B0pol/second
TobiGr Mar 13, 2020
89e3292
Move code with lower priority to the bottom of the file
mauriciocolli Mar 13, 2020
d247d32
Change share title as well to differentiate multiple builds
mauriciocolli Mar 13, 2020
0e2f062
Disable database destructive migration fallback
mauriciocolli Apr 28, 2019
e8ab5aa
Setup initial database for feed implementation
mauriciocolli Apr 28, 2019
20a4bb0
Implement new feed and subscriptions groups
mauriciocolli Apr 28, 2019
f69b6c8
Fix alignment issues in group creator dialog
mauriciocolli Oct 7, 2019
a93e2cd
Quick fix for NPE when exiting the feed fragment
mauriciocolli Oct 9, 2019
8b87893
Update Groupie list library to v2.7.0
mauriciocolli Oct 10, 2019
f05b8c9
Expand import/export options by default when subscriptions list is empty
mauriciocolli Oct 10, 2019
2948e41
Change feed groups header title and icon from feed representing "All"
mauriciocolli Oct 11, 2019
b2f317a
Load only the selected group and customizable updated status timeout
mauriciocolli Dec 16, 2019
5ea323c
New option to use dedicated feed sources for services that support it
mauriciocolli Dec 16, 2019
3f32573
Replace hardcoded value that represents the group "All" with a constant
mauriciocolli Jan 28, 2020
2c783ff
Stick info header when selecting subscriptions in the feed group dialog
mauriciocolli Jan 30, 2020
18a4016
Add Groupie library to the credit list in the about page
mauriciocolli Feb 16, 2020
50714c3
Add ability to cancel a feed update through a notification action
mauriciocolli Feb 16, 2020
d1d5f68
Implement feed groups manual sorting
mauriciocolli Feb 26, 2020
34082c4
Fix behavior of the feed group dialog under some screen sizes/scales
mauriciocolli Feb 29, 2020
597859e
Disable buttons when processing actions in the feed dialogs
mauriciocolli Mar 5, 2020
98c65d8
Don't expose MutableLiveData in view models
mauriciocolli Mar 5, 2020
d8b9d35
Add a confirmation dialog when deleting a feed group
mauriciocolli Mar 5, 2020
f01e40e
Simplify screen handling in feed group dialog
mauriciocolli Mar 5, 2020
b62142d
Detect if the subscription list should be shown as a grid
mauriciocolli Mar 6, 2020
ac44ed0
Localize duration strings used in feed settings using plurals
mauriciocolli Mar 6, 2020
6a9a0f1
Add tests for migrations in the Room database
mauriciocolli Mar 7, 2020
a4babc1
Merge pull request #3225 from mauriciocolli/improve-build-branch
TobiGr Mar 14, 2020
97f5490
Add help dialog to feed screen
mauriciocolli Mar 14, 2020
f8cc318
Merge pull request #2309 from mauriciocolli/feed
TobiGr Mar 14, 2020
878a5db
Translated using Weblate (German)
nautilusx Mar 13, 2020
dc1312d
Translated using Weblate (Esperanto)
B0pol Mar 13, 2020
0486ccb
Translated using Weblate (Macedonian)
Mar 13, 2020
fcc8066
Translated using Weblate (Polish)
weblate Mar 12, 2020
0876cdd
Translated using Weblate (Interlingua)
softinterlingua Mar 12, 2020
373ec96
Translated using Weblate (Nepali)
hemanta212 Mar 13, 2020
eacd21b
update extractor version
B0pol Mar 15, 2020
c4a601b
Merge pull request #3090 from B0pol/mediaccc
TobiGr Mar 15, 2020
0ab4b6d
Delete subscription_header.xml
Stypox Mar 15, 2020
be5654d
Merge pull request #3233 from TeamNewPipe/delete-subscription-header
wb9688 Mar 15, 2020
df2a383
Revert manifest removal from build variant
mauriciocolli Mar 15, 2020
0f96f3b
Translated using Weblate (Nepali)
hemanta212 Mar 15, 2020
ce15697
Merge pull request #3234 from mauriciocolli/revert-manifest-removal
TobiGr Mar 16, 2020
436b08a
Translated using Weblate (Nepali)
hemanta212 Mar 16, 2020
e83e755
dropping markdown links in comments
Poolitzer Mar 19, 2020
02ef0b0
a document is not nice
Poolitzer Mar 19, 2020
b1c72ba
Merge remote-tracking branch 'weblate/dev'
mauriciocolli Mar 19, 2020
d0f2a02
delete «seconds» plural string in favor of «dynamic_seek_duration_des…
B0pol Mar 15, 2020
0ae4d13
use plural string for feed_group_dialog_selection_count
B0pol Mar 15, 2020
85e16af
use val instead of val, make sentence more natural
B0pol Mar 18, 2020
27fc0d5
Make duration plurals naming consistent
mauriciocolli Mar 19, 2020
fb3290e
Merge pull request #3230 from B0pol/seconds
mauriciocolli Mar 19, 2020
49c6aa2
Update .github/ISSUE_TEMPLATE/feature_request.md
TobiGr Mar 19, 2020
4d4fb9f
Merge branch 'master' into dev
TobiGr Mar 19, 2020
b4a5f29
Translated using Weblate (German)
nautilusx Mar 19, 2020
8b45256
Translated using Weblate (Hebrew)
yarons Mar 19, 2020
565a5ab
Translated using Weblate (Indonesian)
zmni Mar 19, 2020
ac9057b
Translated using Weblate (Slovak)
marulinko Mar 19, 2020
60bcd70
Translated using Weblate (Norwegian Bokmål)
comradekingu Mar 19, 2020
37f4469
Merge branch 'origin/dev' into Weblate.
weblate Mar 19, 2020
cab104a
Merge pull request #3132 from Poolitzer/templates
TobiGr Mar 19, 2020
50fd10e
Remove titles from issue templates and fix typo
TobiGr Mar 19, 2020
27156d7
Merge pull request #3220 from kapodamy/webm-seek-fix
TobiGr Mar 20, 2020
0a412e2
Remove search icon in search mode. Issue: #3183 (see PR #3193)
jonas-skywalker Mar 20, 2020
47c5008
Change mute button color for more visibility
B0pol Mar 21, 2020
c54ac32
mute button color for queue
B0pol Mar 21, 2020
8d068b3
remove unused imports
B0pol Mar 21, 2020
bb91b16
use 8F instead of 6f for white hexadecimal, on @wb9688 advise
B0pol Mar 21, 2020
3e348f8
Translated using Weblate (German)
nautilusx Mar 20, 2020
a86912c
Translated using Weblate (Nepali)
hemanta212 Mar 20, 2020
b31fbc3
Translated using Weblate (Spanish)
j9o1 Mar 19, 2020
ebb1389
Translated using Weblate (French)
B0pol Mar 19, 2020
a433e5b
Translated using Weblate (Chinese (Traditional))
s8321414 Mar 20, 2020
da5369e
Merge branch 'origin/dev' into Weblate.
weblate Mar 23, 2020
5a8b565
Merge pull request #3252 from B0pol/mute_button
TobiGr Mar 23, 2020
4524a69
Update extractor version
TobiGr Mar 25, 2020
3290478
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr Mar 25, 2020
6eeb229
Fix what Weblate screwed up again
TobiGr Mar 25, 2020
6ac52f2
Do not show nothing for some quantities for Chinese
TobiGr Mar 25, 2020
60252bb
Remove unused "playback_default" string
TobiGr Mar 25, 2020
a19be79
Remove unused "clear_finished_download" string
TobiGr Mar 25, 2020
5f940c4
fix integer overflow
kapodamy Mar 25, 2020
452f258
Merge pull request #3273 from kapodamy/int-overflow-fix
TobiGr Mar 25, 2020
93b75b6
Update extractor version
TobiGr Mar 25, 2020
55c577e
Seek duration should not be rounded up when opening the settings, eve…
TobiGr Mar 25, 2020
c6de6e5
Translated using Weblate (Portuguese (Brazil))
Mar 26, 2020
2e3f240
Translated using Weblate (Turkish)
emintufan Mar 23, 2020
838f8cb
Translated using Weblate (Portuguese (Brazil))
weblate Mar 26, 2020
8168445
Translated using Weblate (German)
nautilusx Mar 24, 2020
1994dad
Translated using Weblate (German)
franconian Mar 25, 2020
89dc5ce
Translated using Weblate (Esperanto)
B0pol Mar 23, 2020
782b983
Translated using Weblate (Asturian)
enolp Mar 24, 2020
6e3170f
Translated using Weblate (Japanese)
AioiLight Mar 26, 2020
c4f58cb
Translated using Weblate (Czech)
zeritti Mar 24, 2020
aef673a
Translated using Weblate (Croatian)
Stipess1 Mar 26, 2020
39bb0f4
Translated using Weblate (Croatian)
weblate Mar 26, 2020
4cd5afa
Translated using Weblate (Hebrew)
yarons Mar 24, 2020
c687d83
Translated using Weblate (Italian)
pjammo Mar 25, 2020
4d23cf7
Translated using Weblate (Dutch)
wb9688 Mar 25, 2020
082b7fa
Translated using Weblate (French)
B0pol Mar 25, 2020
5447518
Translated using Weblate (Kurdish)
ShexSMohammed Mar 23, 2020
9a980f9
Translated using Weblate (Chinese (Simplified))
Mar 23, 2020
aa87f10
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr Mar 26, 2020
6ce338b
Weblate ...
TobiGr Mar 26, 2020
c6eaed7
Translation fixes
TobiGr Mar 26, 2020
d8e83da
Temporary: Fix menu visibility when restoring state in the pager adapter
mauriciocolli Mar 27, 2020
bbd8751
Merge pull request #3281 from mauriciocolli/fix-main-screen-menu-crea…
TobiGr Mar 28, 2020
f133bbf
Introduce a proper way to find urls in a string input
mauriciocolli Mar 27, 2020
4dc2898
Fix bug when searching for urls from shared content
mauriciocolli Mar 27, 2020
d051df9
Merge pull request #3278 from mauriciocolli/fix-url-parsing-share
TobiGr Mar 28, 2020
f9b718f
Use correct class for getting a vector drawable in older APIs
mauriciocolli Mar 28, 2020
40de014
Merge pull request #3283 from Stypox/fix-mute-button
TobiGr Mar 28, 2020
b4cabe2
Handle content not available exception more comprehensively
mauriciocolli Mar 27, 2020
7c72f17
Merge pull request #3279 from mauriciocolli/fix-not-found-handling
TobiGr Mar 28, 2020
949150f
Update extractor version
TobiGr Mar 28, 2020
3c3848d
Fix UI crash in Settings, Content (chinese language)
vlt23 Mar 28, 2020
505a689
Merge pull request #3292 from vlt23/dev
TobiGr Mar 28, 2020
bcd7703
Add changelog
TobiGr Mar 25, 2020
7f21975
release version 0.19.0 (900)
TobiGr Mar 25, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

44 changes: 44 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
---
name: Bug report
about: Create a bug report to help us improve
labels: bug
assignees: ''

---

<!--
Oh no, a bug! It happens. Thanks for reporting an issue with NewPipe.

Use this template to notify us if you found a bug.

To make it easier for us to help you please enter detailed information below.

Please note, we only support the latest version of NewPipe and the master branch. Make sure you have that version installed. If you don't, upgrade & reproduce the problem before opening the issue. The release page (https://github.com/TeamNewPipe/NewPipe/releases/latest) is the go-to place to get this version. In order to check your app version, open the left drawer and click on "About".

P.S.: Our contribution guidelines might be a nice document to read before you fill out the report :) You can find it at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md
-->
### Version
<!-- Which version are you using? -->
-


### Steps to reproduce the bug
<!-- If you can't reproduce it, please try to give as many details as possible on how you think you got to the bug. -->
Steps to reproduce the behavior:
1. Go to '...'
2. Press on '....'
3. Swipe down to '....'

### Expected behavior
Tell us what you expected to happen.

### Actual behaviour
Tell us what happens instead.

### Screenshots/Screen records
If applicable, add screenshots or a screen recording to help explain your problem. GitHub should support uploading them directly in the issue field. If your file is too big, feel free to paste a link from an image/video hoster here instead.

### Logs
If your bug includes a crash, please head over to the [incredible bugreport to markdown converter](https://teamnewpipe.github.io/CrashReportToMarkdown/). Copy the result. Paste it here:

<!-- That's right, here! -->
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: Feature request
about: Suggest an idea for this project
labels: enhancement
assignees: ''

---
<!-- Hey. Our contribution guidelines (https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md) might be an appropriate
document to read before you fill out the request :) -->
#### Is your feature request related to a problem? Please describe it
A clear and concise description of what the problem is.
Example: *I want to do X, but there is no way to do it.*

#### Describe the solution you'd like
A clear and concise description of what you want to happen.
Example: *I think it would be nice if you add feature Y which makes X possible.*

#### (Optional) Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Example: *I considered Z, but that didn't turn out to be a good idea because...*

#### Additional context
Add any other context or screenshots about the feature request here.
Example: *Here's a photo of my cat!*

#### How will you/everyone benefit from this feature?
Convince us! How does it change your NewPipe experience and/or your life?
The better this paragraph is, the more likely a developer will think about working on it.
25 changes: 25 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1 +1,26 @@
<!-- Hey there. Thank you so much for improving NewPipe. Please take a moment to fill out the following suggestion on how to structure this PR description. Having roughly the same layout helps everyone considerably :)-->

#### What is it?
- [ ] Bug fix
- [ ] Feature

#### Long description of the changes in your PR
<!-- While bullet points are the norm in this section, feel free to write a text instead if you can't fit it in a list -->
- record videos
- create clones
- take over the world

#### Fixes the following issue(s)
<!-- Also add reddit or other links which are relevant to your change. -->
-

#### Relies on the following changes
<!-- Delete this if it doesn't apply to you. -->
-

#### Testing apk
<!-- Ensure that you have your changes on a new branch which has a meaningful name. This name will be used as a suffix for the app ID to allow installing and testing multiple versions of NewPipe. Do NOT name your branches like "patch-0" and "feature-1". For example, if your PR implements a bug fix for comments, an appropriate branch name would be "commentfix". -->
debug.zip

#### Agreement
- [ ] I carefully read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md) and agree to them.
60 changes: 56 additions & 4 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,20 @@ android {

defaultConfig {
applicationId "org.schabi.newpipe"
resValue "string", "app_name", "NewPipe"
minSdkVersion 19
targetSdkVersion 28
versionCode 870
versionName "0.18.7"
versionCode 900
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why increase by 30? It was a coincidence that e.g. 0.18.7 was 870 and it should just be increased by 10 like always imho. However now it's already too late.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why though? It's nice to be consistent. In fact, I would prefer 1910 for 0.19.1 and eventually, 10000 for 1.0.0. It's just symbolic.

Copy link
Contributor Author

@TobiGr TobiGr Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I agree with opus.
I think we can do this when going 1.0.0 which should be soon after #2907 is merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste of my argument on IRC:

With his 10000 example it's still not possible to give a "correct" version code for e.g. 1.0.10. I don't think we should have ridiculously long version codes, though that doesn't really matter since we probably won't hit the 32-bit limit that soon. Also, version codes are purely for Android to check whether an APK is newer than the currently installed one. Version codes aren't for users to see, that's what version names are for. Google says: " Typically, you would release the first version of your app with versionCode set to 1, then monotonically increase the value with each release, regardless of whether the release constitutes a major or minor release. This means that the versionCode value does not necessarily have a strong resemblance to the app release version that is visible to the user (see versionName, below). Apps and publishing services should not display this version value to users." Iirc TheAssassin once argued that we shouldn't just increase by 1 every time, but by 10, which he had a reason for, so we switched to that. Imho it just doesn't make sense to somehow tie it to the version names.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much easier and foreseeable IMO to just increase by the ever same amount. The interval of 10 isn't even really needed any more, but we should keep it. As @wb9688 showed, any "binding" to a version code doesn't work, there's always cases in which it breaks. A version code is 3 integers, not 1.

versionName "0.19.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true

javaCompileOptions {
annotationProcessorOptions {
arguments = ["room.schemaLocation": "$projectDir/schemas".toString()]
}
}
}

buildTypes {
Expand All @@ -28,7 +35,18 @@ android {
debug {
multiDexEnabled true
debuggable true
applicationIdSuffix ".debug"

// suffix the app id and the app name with git branch name
def workingBranch = getGitWorkingBranch()
def normalizedWorkingBranch = workingBranch.replaceAll("[^A-Za-z]+", "").toLowerCase()
if (normalizedWorkingBranch.isEmpty() || workingBranch == "master" || workingBranch == "dev") {
// default values when branch name could not be determined or is master or dev
applicationIdSuffix ".debug"
resValue "string", "app_name", "NewPipe Debug"
} else {
applicationIdSuffix ".debug." + normalizedWorkingBranch
resValue "string", "app_name", "NewPipe " + workingBranch
}
}
}

Expand All @@ -43,6 +61,15 @@ android {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

// Required and used only by groupie
androidExtensions {
experimental = true
}

sourceSets {
androidTest.assets.srcDirs += files("$projectDir/schemas".toString())
}
}

ext {
Expand All @@ -59,11 +86,13 @@ ext {
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

androidTestImplementation 'androidx.test.ext:junit:1.1.1'
androidTestImplementation "android.arch.persistence.room:testing:1.1.1"
androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0', {
exclude module: 'support-annotations'
})

implementation 'com.github.TeamNewPipe:NewPipeExtractor:6f03c6e87'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:69e0624e3'
testImplementation 'junit:junit:4.12'
testImplementation 'org.mockito:mockito-core:2.23.0'

Expand All @@ -75,6 +104,13 @@ dependencies {
implementation "androidx.cardview:cardview:${androidxLibVersion}"
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'

implementation 'com.xwray:groupie:2.7.0'
implementation 'com.xwray:groupie-kotlin-android-extensions:2.7.0'

implementation 'androidx.lifecycle:lifecycle-livedata:2.0.0'
implementation 'androidx.lifecycle:lifecycle-viewmodel:2.0.0'
implementation 'androidx.lifecycle:lifecycle-extensions:2.0.0'

// Originally in NewPipeExtractor
implementation 'com.grack:nanojson:1.1'
implementation 'org.jsoup:jsoup:1.9.2'
Expand Down Expand Up @@ -113,3 +149,19 @@ dependencies {
implementation "io.noties.markwon:core:${markwonVersion}"
implementation "io.noties.markwon:linkify:${markwonVersion}"
}

static String getGitWorkingBranch() {
try {
def gitProcess = "git rev-parse --abbrev-ref HEAD".execute()
gitProcess.waitFor()
if (gitProcess.exitValue() == 0) {
return gitProcess.text.trim()
} else {
// not a git repository
return ""
}
} catch (IOException ignored) {
// git was not found
return ""
}
}
Loading