YouTube Music search stuff #3240

wb9688 · 2020-03-17T10:43:49Z

I carefully read the contribution guidelines and agree to them.

See TeamNewPipe/NewPipeExtractor#291.

wb9688 · 2020-03-20T11:34:50Z

@opusforlife2: Here is a test APK, in case you wanted to test it, since you opened #3202.

opusforlife2 · 2020-03-20T11:39:03Z

Yay! I'm gonna use this so much. ಠ‿ಠ

Edit: I love you. (づ￣ ³￣)づ

opusforlife2 · 2020-03-20T14:18:37Z

This occurs for all 4 "Music/" options

Exception

User Action: searched
Request: megaman x3
Content Language: en_US
Service: YouTube
Version: 0.18.7
OS: Linux Android 9 - 28

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'com.grack.nanojson.JsonArray com.grack.nanojson.JsonObject.getArray(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getInitialPage(YoutubeSearchExtractor.java:198)
	at org.schabi.newpipe.extractor.utils.ExtractorHelper.getItemsPageOrLogError(ExtractorHelper.java:19)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:50)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$searchFor$0(ExtractorHelper.java:82)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$BBduYDeZ_vXMQYaemaggmTPtqvA.call(Unknown Source:8)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)

wb9688 · 2020-03-20T14:40:29Z

@opusforlife2: Could confirm. It's caused by that "Did you mean: mega man x3" thing at the top. I'll fix it in a few minutes.

Edit: fixed and updated APK.

opusforlife2 · 2020-03-20T15:18:12Z

I would like a way to stay on Youtube Music when autoplay is on. But right now there's no guarantee that the next suggested video is a YT Music audio. That was basically what I wanted when I mentioned having YT Music as a separate selectable service. The ability to restrict all calls to music.youtube.com only.

wb9688 · 2020-03-20T15:27:53Z

@opusforlife2: Autoplay in NewPipe is YouTube autoplay. What you also want is support for YouTube Music mixes, which are also different from YouTube mixes (that will be added by TeamNewPipe/NewPipeExtractor#280). Could you open a separate issue for that? Thanks!

opusforlife2 · 2020-03-20T16:21:51Z

Edit: fixed and updated APK.

Werks!

mauriciocolli

One thing to keep in mind is that videos on YouTube Music returns different titles from the normal version, so it will change when opening them. I guess is not a huge issue though?

app/src/main/res/values/strings.xml

opusforlife2 · 2020-03-21T15:07:15Z

Occurs for all 4 options, again.

Exception

User Action: searched
Request: ryfffhfff
Content Language: en_US
Service: YouTube
Version: 0.18.7
OS: Linux Android 9 - 28

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'com.grack.nanojson.JsonObject com.grack.nanojson.JsonObject.getObject(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor.getSearchSuggestion(YoutubeSearchExtractor.java:182)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:45)
	at org.schabi.newpipe.extractor.search.SearchInfo.getInfo(SearchInfo.java:30)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$searchFor$0(ExtractorHelper.java:82)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$BBduYDeZ_vXMQYaemaggmTPtqvA.call(Unknown Source:8)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)

wb9688 · 2020-03-21T20:02:30Z

@opusforlife2: I don't have that issue, though I think I've fixed it.

opusforlife2 · 2020-03-21T20:47:38Z

Fixed!

Suggestion: Just like you put YouTube Music above the bottom 4 filters, why not put YouTube above the top 4? It'll look consistent and clearer to the user as well.

TobiGr

Frontend looks good to me

mauriciocolli · 2020-03-23T18:58:34Z

app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java

+            if (filter.equals("music_songs")) {
+                MenuItem musicItem = menu.add(2,
+                        itemId++,
+                        0,
+                        "YouTube Music");
+                musicItem.setEnabled(false);
+            }


Yeah, adding a disabled item as a header title is bad...

Though I don't know if something like that can even be implemented in a native way (closest thing would be a sub-menu), and I'm not sure if it's worth it to add custom components when this option will be improved in the near future.

Will we just leave it like this until that day?

No, this couldn't be implemented in a native way other than submenus. I told Tobias that I didn't really like using a disabled item for that, but he seems to be fine with it until we improve the whole search filter thing some day.

Yeah, adding a disabled item as a header title is bad...

Yes. I hope that we will get proper search filter soon.

Stypox

Looks good. @TobiGr it should be merged after TeamNewPipe/NewPipeExtractor#280 and #3243 are ready

wb9688 · 2020-04-04T14:58:31Z

@TobiGr: I just rebased this PR.

TobiGr · 2020-04-06T19:52:09Z

@Stypox Why should this be merged after TeamNewPipe/NewPipeExtractor#280 and #3243?

wb9688 · 2020-04-07T05:19:26Z

@TobiGr: He said that because it depends on the commits to add support for showing 100+/unlimited/unknown streams for playlists. However, I've added the relevant commits to this PR as you could see.

Stypox · 2020-04-10T07:53:38Z

@TobiGr oh ok, then merge it, the other ones can be rebased afterwards

ITEM_COUNT_INFINITE and ITEM_COUNT_MORE_THAN_100. Use localizeStreamCount in PlaylistFragment and PlaylistItemHolder

Note: more_than_100_videos_mini and infinite_videos_mini are untranslatable

wb9688 mentioned this pull request Mar 20, 2020

Show radio icon as uploader avatar in Youtube mixes #3243

Merged

1 task

wb9688 added feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/ labels Mar 20, 2020

opusforlife2 mentioned this pull request Mar 20, 2020

[Feature Request] Support Youtube Music mixes #3250

Closed

mauriciocolli reviewed Mar 20, 2020

View reviewed changes

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

wb9688 mentioned this pull request Mar 22, 2020

Phone crashes when opening "What's New" in the latest two versions #3255

Closed

TobiGr previously approved these changes Mar 23, 2020

View reviewed changes

mauriciocolli reviewed Mar 23, 2020

View reviewed changes

Stypox previously approved these changes Mar 24, 2020

View reviewed changes

wb9688 dismissed stale reviews from Stypox and TobiGr via 18279b4 April 4, 2020 14:58

TobiGr added this to the 0.19.3 milestone Apr 6, 2020

opusforlife2 mentioned this pull request Apr 8, 2020

Thumbnail for Downloads #3389

Closed

Stypox previously approved these changes Apr 10, 2020

View reviewed changes

Stypox added 2 commits April 10, 2020 10:35

Add support for INFINITE_ and MORE_THAN_100_ITEMS in playlists

2710d9d

Detect ITEM_COUNT_* in localizeStreamCount()

625419a

ITEM_COUNT_INFINITE and ITEM_COUNT_MORE_THAN_100. Use localizeStreamCount in PlaylistFragment and PlaylistItemHolder

Stypox and others added 6 commits April 10, 2020 10:35

Also use localizeStreamCount() in local items

2b47a1b

Use "mini" stream count alternatives for info items

914d3c4

Note: more_than_100_videos_mini and infinite_videos_mini are untranslatable

Use ITEM_COUNT_UNKNOWN

63e489f

Add ability to translate YouTube Music search options

41a1006

Use suggested layout for search filters

2852815

Bump NewPipeExtractor version

9bbd03c

wb9688 dismissed Stypox’s stale review via 9bbd03c April 10, 2020 08:38

Stypox approved these changes Apr 10, 2020

View reviewed changes

wb9688 merged commit bd9b2d5 into TeamNewPipe:dev Apr 10, 2020

This was referenced Apr 24, 2020

Release 0.19.3 #3478

Merged

Release 0.19.3 #3479

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YouTube Music search stuff #3240

YouTube Music search stuff #3240

wb9688 commented Mar 17, 2020

wb9688 commented Mar 20, 2020 •

edited

Loading

opusforlife2 commented Mar 20, 2020 •

edited

Loading

opusforlife2 commented Mar 20, 2020 •

edited

Loading

wb9688 commented Mar 20, 2020 •

edited

Loading

opusforlife2 commented Mar 20, 2020

wb9688 commented Mar 20, 2020

opusforlife2 commented Mar 20, 2020

mauriciocolli left a comment

opusforlife2 commented Mar 21, 2020

wb9688 commented Mar 21, 2020

opusforlife2 commented Mar 21, 2020

TobiGr left a comment

mauriciocolli Mar 23, 2020

wb9688 Mar 23, 2020 •

edited

Loading

TobiGr Mar 23, 2020

Stypox left a comment

wb9688 commented Apr 4, 2020

TobiGr commented Apr 6, 2020

wb9688 commented Apr 7, 2020 •

edited

Loading

Stypox commented Apr 10, 2020

YouTube Music search stuff #3240

YouTube Music search stuff #3240

Conversation

wb9688 commented Mar 17, 2020

wb9688 commented Mar 20, 2020 • edited Loading

opusforlife2 commented Mar 20, 2020 • edited Loading

opusforlife2 commented Mar 20, 2020 • edited Loading

Exception

wb9688 commented Mar 20, 2020 • edited Loading

opusforlife2 commented Mar 20, 2020

wb9688 commented Mar 20, 2020

opusforlife2 commented Mar 20, 2020

mauriciocolli left a comment

Choose a reason for hiding this comment

opusforlife2 commented Mar 21, 2020

Exception

wb9688 commented Mar 21, 2020

opusforlife2 commented Mar 21, 2020

TobiGr left a comment

Choose a reason for hiding this comment

mauriciocolli Mar 23, 2020

Choose a reason for hiding this comment

wb9688 Mar 23, 2020 • edited Loading

Choose a reason for hiding this comment

TobiGr Mar 23, 2020

Choose a reason for hiding this comment

Stypox left a comment

Choose a reason for hiding this comment

wb9688 commented Apr 4, 2020

TobiGr commented Apr 6, 2020

wb9688 commented Apr 7, 2020 • edited Loading

Stypox commented Apr 10, 2020

wb9688 commented Mar 20, 2020 •

edited

Loading

opusforlife2 commented Mar 20, 2020 •

edited

Loading

opusforlife2 commented Mar 20, 2020 •

edited

Loading

wb9688 commented Mar 20, 2020 •

edited

Loading

wb9688 Mar 23, 2020 •

edited

Loading

wb9688 commented Apr 7, 2020 •

edited

Loading