Add support for tabs #3201

wb9688 · 2020-03-08T14:36:19Z

I carefully read the contribution guidelines and agree to them.

Currently it looks like the following:

Videos tab	Playlists tab

You could download a test APK here.

To do:

Show the subscribe count and button
Show placeholder for avatar and banner while loading or when there is none
Show 'No items' instead of 'No videos'
Make the queue working again (~~though I've no idea how to do that as a tab could contain both streams and playlists~~ just for the stream-only tabs)
Show tab names at the top instead of dots at the bottom
Clean up the code
Fix crash when opening item in channel on homepage
Localize tab names
Fix location of loading animation and network error

Fixes #3237

Also see TeamNewPipe/NewPipeExtractor#279.

Stypox · 2020-03-08T14:43:34Z

I am not sure it is a good idea to use those bubbles on the bottom to switch to different tabs. I think a pager like in the MainActivity would suit better, since in the future we could add new tabs for channels (e.g. related/suggested channels, channel description, ...), and having a small label for every tab would make things more clear and easily-accessible to the user imo.

wb9688 · 2020-03-08T14:52:43Z

@Stypox: I agree. What exactly do you mean with 'a small label' though? Just the name of the tab (e.g. 'Videos' or 'Popular tracks')?

Stypox

The approach is ok, in my opinion

app/src/main/java/org/schabi/newpipe/fragments/detail/ChannelDetailFragment.java

app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelTabFragment.java

Stypox · 2020-03-08T15:02:41Z

@Stypox: I agree. What exactly do you mean with 'a small label' though? Just the name of the tab (e.g. 'Videos' or 'Popular tracks')?

Yeah ;-)

heberjeur · 2020-03-10T23:00:54Z

I found this error
https://youtu.be/90wuJhtQlqE

app/src/main/res/layout/fragment_channel_detail.xml

wb9688 · 2020-03-14T15:28:32Z

I updated the screenshots and test APK.

opusforlife2 · 2020-03-14T19:50:31Z

Would you please rename the package for adjacent installation with other apks?

B0pol · 2020-03-14T19:58:59Z

Would you please rename the package for adjacent installation with other apks?

Rebase because it will also include fixed feed

B0pol

Please avoid duplicates next time. Otherwise you're ordering community to translate something they already translated, we should not do that.

app/src/main/res/values/strings.xml

wb9688 · 2020-03-15T10:11:47Z

app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionManager.kt

@@ -27,7 +27,7 @@ class SubscriptionManager(context: Context) {

        database.runInTransaction {
            infoList.forEachIndexed { index, info ->
-                feedDatabaseManager.upsertAll(listEntities[index].uid, info.relatedItems)
+                feedDatabaseManager.upsertAll(listEntities[index].uid, info.tabs[0].relatedItems as List<StreamInfoItem>)


Is there a better solution for this?

wb9688 · 2020-03-15T10:59:24Z

@opusforlife2 and @B0pol: I just rebased and updated the APK.

wb9688 · 2020-03-15T15:36:02Z

app/src/main/java/org/schabi/newpipe/player/playqueue/ChannelPlayQueue.java

@@ -39,9 +32,9 @@ public void fetch() {
            ExtractorHelper.getChannelInfo(this.serviceId, this.baseUrl, false)
                    .subscribeOn(Schedulers.io())
                    .observeOn(AndroidSchedulers.mainThread())
-                    .subscribe(getHeadListObserver());
+                    .subscribe((Consumer<? super ChannelInfo>) getHeadListObserver());


I don't think I did this part correctly and I'm not sure what this even is supposed to do, though I don't think it breaks anything when I remove it.

wb9688 · 2020-03-15T15:38:50Z

@TobiGr: I think this PR is almost finished now. I highlighted 2 issues above, plus I need to make the playlist controls not sticky. @B0pol also discovered some SoundCloud issue, where it sometimes stops working completely for a few minutes, which I've reproduced once, but I'm not sure what causes it.

wb9688 · 2020-03-15T15:51:36Z

Another bug found by @B0pol: when a channel only has one tab (i.e. media.ccc.de or PeerTube) and you press back, it crashes.

Edit: fixed.

opusforlife2 · 2020-03-15T16:22:15Z

Something is wrong. The feed update process is broken. It doesn't load even a single one successfully. Tapping on Report doesn't even show the errors. It just closes the app. I'm not sure if that's caused by this PR or mauricio's code.

wb9688 · 2020-03-15T16:28:48Z

@opusforlife2: I could confirm that, however it shows the errors for me. I'll look into that.

wb9688 · 2020-03-15T17:36:46Z

@opusforlife2: I fixed your issue and rebased it (again). I'll upload the new APK in a minute.

opusforlife2 · 2020-03-15T17:53:06Z

Confirmed fixed.

Edit: Wow! Channel loading is super fast. Placebo or your code?

opusforlife2 · 2020-03-16T03:33:37Z

Another bug, but it is also present in cool-student's PR. When you open the app through a link from another app, the name of the app "Newpipe tabs" flashes for a moment at the place where the resolution drop down is. For his PR, it's "Newpipe notification", naturally. This doesn't happen in the release apk.

Which means it's something in the dev branch causing the issue.

wb9688 · 2020-03-16T05:14:44Z

@opusforlife2: Please just create a new issue for that as that isn't caused by this PR.

opusforlife2 · 2020-03-16T11:14:52Z

That... is a very good point. Not sure what I was thinking. Brain fart.

opusforlife2 · 2020-03-20T17:24:01Z

Error when switching tabs on a SoundCloud user page.

Also, why does Newpipe lose the backstack when you open the error report page? Isn't that a bug?

Exception

User Action: requested channel
Request: https://soundcloud.com/eminemofficial
Content Language: en_US
Service: SoundCloud
Version: 0.18.6
OS: Linux Android 9 - 28

Crash log

org.schabi.newpipe.extractor.exceptions.ExtractionException: Could not get next page
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudChannelAlbumsExtractor.computeNextPageAndGetPlaylists(SoundcloudChannelAlbumsExtractor.java:61)
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudChannelAlbumsExtractor.getInitialPage(SoundcloudChannelAlbumsExtractor.java:37)
	at org.schabi.newpipe.extractor.utils.ExtractorHelper.getItemsPageOrLogError(ExtractorHelper.java:19)
	at org.schabi.newpipe.extractor.channel.ChannelTabInfo.loadTab(ChannelTabInfo.java:67)
	at org.schabi.newpipe.fragments.list.channel.ChannelTabFragment.lambda$loadResult$0$ChannelTabFragment(ChannelTabFragment.java:84)
	at org.schabi.newpipe.fragments.list.channel.-$$Lambda$ChannelTabFragment$WuJ37aw-7UKTbW8f72jXH9kxJGI.call(Unknown Source:2)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)
Caused by: java.io.InterruptedIOException: interrupted
	at okio.Timeout.throwIfReached(Timeout.java:146)
	at okio.Okio$1.write(Okio.java:76)
	at okio.AsyncTimeout$1.write(AsyncTimeout.java:180)
	at okio.RealBufferedSink.flush(RealBufferedSink.java:224)
	at okhttp3.internal.http1.Http1Codec.finishRequest(Http1Codec.java:166)
	at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.java:84)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
	at com.facebook.stetho.okhttp3.StethoInterceptor.intercept(StethoInterceptor.java:56)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:45)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:127)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:257)
	at okhttp3.RealCall.execute(RealCall.java:93)
	at org.schabi.newpipe.DownloaderImpl.execute(DownloaderImpl.java:159)
	at org.schabi.newpipe.extractor.downloader.Downloader.get(Downloader.java:70)
	at org.schabi.newpipe.extractor.downloader.Downloader.get(Downloader.java:42)
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudParsingHelper.getPlaylistsFromApi(SoundcloudParsingHelper.java:312)
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudParsingHelper.getPlaylistsFromApiMinItems(SoundcloudParsingHelper.java:300)
	at org.schabi.newpipe.extractor.services.soundcloud.SoundcloudChannelAlbumsExtractor.computeNextPageAndGetPlaylists(SoundcloudChannelAlbumsExtractor.java:59)
	... 16 more

wb9688 · 2020-03-20T17:38:01Z

@opusforlife2: I can't reproduce that error.

About the backstack: I've no idea. I had code related to that inherited from the VideoDetailFragment, but that seemed to cause crashes here, so I removed that code, which seemed to work.

opusforlife2 · 2020-03-20T17:43:10Z

Keep opening some User pages. You'll eventually hit it. I originally got it with an unofficial Daft Punk page, but then it stopped happening. I thought it was a one off, but then it happened here.

What basically happens is that Newpipe is either able to load the tabs properly, in which case the error is unlikely to appear at all. But if it takes time to load the first tab, chances are that one of the other ones will give the error.

For example, when I hit the error with the Eminem page, the Tracks tab was empty. But when I opened it again a few times, Tracks was populated.

Stypox · 2020-03-20T21:17:54Z

@opusforlife2 for the backstack: that's not something that can be prevented, I think. When the app crashes... it crashes. The Android is instructed to call a function inside of the app to handle the information about the crash, but everything has already been destroyed.

opusforlife2 · 2020-03-21T04:00:36Z

@Stypox I'm not talking about the case where the app crashes and then automatically shows the error page. I'm talking about when you're happily browsing, then you see an error at the bottom, which you can choose not to open and continue browsing without any issue. But if you open it, you lose the backstack. I don't see why that should be the case. Maybe there's a way to code the page so that if it is opened manually by the user, the backstack shouldn't be discarded?

Also, the button being called "Report" is a bit misleading. It should be called "View" instead. You get the option to report the error only after viewing it.

njmdietrich · 2020-04-04T08:33:11Z

When opening a playlist on YouTube from the playlists tab and then pressing the back button to return to the tab, it opens on the video tab. While the scrolling position of the playlists tab is preserved so switching back to it doesn't cause any issues, the expected behaviour would be to return to the playlist tab immediately.

opusforlife2 · 2020-08-31T15:11:48Z

@NicTanghe Follow this for playlists in channels.

NicTanghe · 2020-08-31T18:15:45Z

Does this anly work for playlists with channels own videos or also playlists with others videos?
Also thx for pointing me here. Altyd grappig om mensen Nederland s te zien gebruiken.

opusforlife2 · 2020-09-01T10:47:21Z

@NicTanghe Probably the channel's own playlists. Can't remember for sure.

BruceMustache · 2020-11-28T02:39:15Z

What happens with this PR?

ghost · 2020-12-06T06:14:47Z

Curious about the PR as well, checked if there were issues filed for it and found this, not sure if any things come from it.

MD77MD · 2021-05-31T19:54:29Z

any hope for this to be merged

alittlebitofit · 2022-05-10T17:58:31Z

Is the apk still updated?
Because I see the loading indicator running forever.
And it says "No Results" when I try to search.

AudricV · 2022-05-10T18:52:13Z

Not at all, this PR was closed and this work has been abandoned.

heberjeur · 2022-05-10T21:49:04Z

@TiA4f8R why?, isn't necessary to add support for tabs ?

Stypox · 2022-05-10T22:14:23Z

Yes it is, since there is an issue open about it which has received endorsements from devs. But nobody is working on this at the moment and the original creator of this PR dropped his work. If somebody wants to work on this, contributions are well accepted.

wb9688 added the feature request Issue is related to a feature in the app label Mar 8, 2020

Stypox reviewed Mar 8, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

wb9688 mentioned this pull request Mar 10, 2020

[Feature Request]Show Playlists inside a YouTube channel #3209

Closed

3 tasks

Stypox reviewed Mar 14, 2020

View reviewed changes

app/src/main/res/layout/fragment_channel_detail.xml Outdated Show resolved Hide resolved

B0pol requested changes Mar 15, 2020

View reviewed changes

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

wb9688 commented Mar 15, 2020

View reviewed changes

wb9688 marked this pull request as ready for review March 15, 2020 15:29

wb9688 commented Mar 15, 2020

View reviewed changes

opusforlife2 mentioned this pull request Mar 16, 2020

Notification Improvements #3178

Merged

1 task

wb9688 mentioned this pull request Mar 16, 2020

Can't download or play newpipe #3232

Closed

3 tasks

opusforlife2 mentioned this pull request Mar 16, 2020

[Bug] Name of app flashes momentarily when opened through 3rd party link #3236

Closed

1 task

TobiGr added this to the 0.19.3 milestone Apr 6, 2020

wb9688 removed this from the 0.19.3 milestone Apr 8, 2020

B0pol mentioned this pull request Apr 11, 2020

Android TV support #2806

Merged

1 task

wb9688 added this to the 0.20.0 milestone Apr 11, 2020

B0pol mentioned this pull request Apr 16, 2020

Support for Channel Tabs #2414

Closed

This was referenced Apr 23, 2020

Slow to open #2678

Closed

Show Channel's Curated Playlists #3489

Closed

B0pol mentioned this pull request May 25, 2020

"what's new" crashes on channels that do not have a videos tab #3646

Closed

wb9688 removed this from the 0.20.0 milestone Jul 13, 2020

opusforlife2 mentioned this pull request Aug 17, 2020

Playlists on channel pages #4146

Closed

wb9688 closed this Oct 24, 2020

MD77MD mentioned this pull request May 31, 2021

Merge some great NewPipe PRs polymorphicshade/NewPipe#49

Open

3 tasks

opusforlife2 mentioned this pull request Jun 7, 2021

[HELP NEEDED] Major planned/missing features #6448

Open

34 tasks

heberjeur mentioned this pull request Apr 3, 2022

Can we have playlist tab in the near future ? #8138

Closed

3 tasks

Add support for tabs #3201

Add support for tabs #3201

Conversation

wb9688 commented Mar 8, 2020 • edited by opusforlife2 Loading

Stypox commented Mar 8, 2020 • edited Loading

wb9688 commented Mar 8, 2020 • edited Loading

Stypox left a comment

Choose a reason for hiding this comment

Stypox commented Mar 8, 2020

This comment has been minimized.

This comment has been minimized.

heberjeur commented Mar 10, 2020

wb9688 commented Mar 14, 2020

opusforlife2 commented Mar 14, 2020

B0pol commented Mar 14, 2020

B0pol left a comment • edited Loading

Choose a reason for hiding this comment

wb9688 Mar 15, 2020

Choose a reason for hiding this comment

wb9688 commented Mar 15, 2020 • edited Loading

wb9688 Mar 15, 2020

Choose a reason for hiding this comment

wb9688 commented Mar 15, 2020

wb9688 commented Mar 15, 2020 • edited Loading

opusforlife2 commented Mar 15, 2020

wb9688 commented Mar 15, 2020

wb9688 commented Mar 15, 2020

opusforlife2 commented Mar 15, 2020 • edited Loading

opusforlife2 commented Mar 16, 2020

wb9688 commented Mar 16, 2020

opusforlife2 commented Mar 16, 2020

opusforlife2 commented Mar 20, 2020

Exception

wb9688 commented Mar 20, 2020

opusforlife2 commented Mar 20, 2020

Stypox commented Mar 20, 2020

opusforlife2 commented Mar 21, 2020

njmdietrich commented Apr 4, 2020

opusforlife2 commented Aug 31, 2020

NicTanghe commented Aug 31, 2020

opusforlife2 commented Sep 1, 2020

BruceMustache commented Nov 28, 2020

ghost commented Dec 6, 2020

MD77MD commented May 31, 2021

alittlebitofit commented May 10, 2022

AudricV commented May 10, 2022

heberjeur commented May 10, 2022

Stypox commented May 10, 2022

wb9688 commented Mar 8, 2020 •

edited by opusforlife2

Loading

Stypox commented Mar 8, 2020 •

edited

Loading

wb9688 commented Mar 8, 2020 •

edited

Loading

B0pol left a comment •

edited

Loading

wb9688 commented Mar 15, 2020 •

edited

Loading

wb9688 commented Mar 15, 2020 •

edited

Loading

opusforlife2 commented Mar 15, 2020 •

edited

Loading