Fix bug in main screen tabs state management #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciocolli
added
ASAP
Stypox
requested changes
Mar 8, 2020
app/src/main/java/org/schabi/newpipe/fragments/MainFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/MainFragment.java
Outdated
Show resolved
Hide resolved
Tabs were not being destroyed/restored correctly due to a call to a method that populated the view pager before it even had a chance of restoring itself. The solution was to null out the adapter before calling that method so the view pager will postpone the populating process.
mauriciocolli
force-pushed
the
fix-main-tabs
branch
from
ee5220c to
f2526ed
Compare
|
Changed the way I fixed the bug. There's also the fact that this class is deprecated and the adapter from the ViewPager2 shoud be used instead, will do the migration in the future. |
Stypox
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs were not being destroyed/restored correctly due to a call to a method that populated the view pager before it even had a chance of restoring itself.
The solution was to null out the adapter before calling that method so the view pager will postpone the populating process.