Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate two settings from Appearance to Content #3184

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Relocate two settings from Appearance to Content #3184

merged 1 commit into from
Mar 8, 2020

Conversation

opusforlife2
Copy link
Collaborator

@opusforlife2 opusforlife2 commented Mar 4, 2020

"Show 'Next' and 'Similar' videos" and "Content of main page" have been relocated from Appearance to Content settings.

APK for testing: app-debug.zip

Closes #3166. Closes #3176.

@opusforlife2
Copy link
Collaborator Author

I think settings would benefit from some reorganisation in general, but I refrained from doing anything other than what was required to fix the issues.

@Stypox
Copy link
Member

Stypox commented Mar 5, 2020

@opusforlife2 even though it is probably not needed, could you provide an apk for testing?
Also, you could open an issue about settings where we could collect ideas about item organization and placement ;-)

@TobiGr
Copy link
Contributor

TobiGr commented Mar 5, 2020

@Stypox good idea.

@opusforlife2
Copy link
Collaborator Author

@Stypox Zip uploaded.

@opusforlife2
Copy link
Collaborator Author

Please make sure you merge this before any conflicting PR. I'm not sure I can handle a merge conflict yet.

@Stypox Stypox self-assigned this Mar 8, 2020
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution :-D
The apk you provided works as expected. I checked in AppearanceSettingsFragment whether there was particular code running behind for the two settings you moved, but there wasn't, so this is good to go!

@Stypox Stypox merged commit 64c289c into TeamNewPipe:dev Mar 8, 2020
@opusforlife2 opusforlife2 deleted the relocate_settings branch March 8, 2020 16:35
@opusforlife2
Copy link
Collaborator Author

Yeah, I was afraid of something like that happening, but I Ctrl+B'd the sh*t out of all the values that I thought could be linked. Android Studio came up with nothing, so I left it to you to see if there was anything I couldn't find.

This was referenced Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants