Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept music.youtube.com in manifest #3177

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Accept music.youtube.com in manifest #3177

merged 1 commit into from
Mar 13, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Mar 2, 2020

This will also need some proper handling in NewPipeExtractor, as videos on YouTube Music will always be in a playlist or mix.

@wb9688 wb9688 mentioned this pull request Mar 2, 2020
Closed
@wb9688 wb9688 added the youtube Service, https://www.youtube.com/ label Mar 2, 2020
@gkeegan
Copy link
Contributor

gkeegan commented Mar 2, 2020

Would be best to wait to merge until it would fully work.

@wb9688
Copy link
Contributor Author

wb9688 commented Mar 2, 2020

Related: TeamNewPipe/NewPipeExtractor#276

PeterHindes
PeterHindes approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@PeterHindes PeterHindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single Line Change Should not break anything.

@TobiGr TobiGr merged commit d23b63c into TeamNewPipe:dev Mar 13, 2020
This was referenced Mar 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterHindes PeterHindes PeterHindes approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
youtube Service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wb9688 @gkeegan @TobiGr @PeterHindes