Mute button #3165
Mute button #3165
Conversation
ghost
changed the title
app/src/main/java/org/schabi/newpipe/player/MainVideoPlayer.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java
Outdated
Show resolved
Hide resolved
|
I am not sure if the mute button should be in the place you put it into. It is not symmetric and looks out of place imho. I think a better place would be the top bar, with a mute menu item that changes name and icon color based on whether mute is active or not. I would also show the menu item with the option "ifRoom", so that if there is no place it is shown in the three-dot menu. I tested the current apk and it works correctly, thanks ;-) |
|
Done! I think this functionality may require translation for other languages now ;) |
| @@ -394,6 +400,11 @@ protected void setShuffleButton(final ImageButton shuffleButton, final boolean s | |||
| shuffleButton.setImageAlpha(shuffleAlpha); | |||
| } | |||
|
|
|||
| protected void setMuteButton(final ImageButton muteButton, final boolean isMuted) { | |||
| muteButton.setColorFilter(ContextCompat.getColor(getApplicationContext(), isMuted ? R.color.white : R.color.gray)); | |||
There was a problem hiding this comment.
What if the theme is white theme? The active button color should be black in that case. I'd suggest adding two attributes in attrs.xml named something along the lines of button_active and button_inactive and giving them different color values in the themes.xml file, so that they are themed.
There was a problem hiding this comment.
White theme does not affect background color for Main video player. Background is always black for this player. So if icon would turn black in WhiteTheme, then it would become invisible ;)
There was a problem hiding this comment.
Oh you are right, nevermind 🤦♂️
Then there should be different code for every player, at this point
There was a problem hiding this comment.
For MainVideoPlayer icon change happens in setMuteButton (place you've mentioned above).
For PopUp and Background, icon change happens for queue in ServicePlayerActivity in onMaybeMuteChanged. I did it similarly to other buttons, (e.g onPlayModeChanged also in ServicePlayerActivity)
|
The grey color of the icon breaks consistency with all the others. Is it not possible to have 2 white icons that switch to one another when toggled? One, a speaker with sound waves, and the other with no sound waves? |
Closes #2876.
Added "Mute button" for MainPlayer, BackgroundPlayer and PopupPlayer.
mute_button-debug.zip