Fixed Weblate bugs and other translation related issues #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) now, on « content language » change, it will also change the app language 2) added Esperanto to the list of language in content language
Stypox
added
the
localisation / translation
This is a hardly reproduceable bug that I hopefully fixed. After a long time of watching videos, you could have your system language shown in playback parameters dialog. Calling changeAppLanguage(getAppLocale(…),…) onCreate will most certainly fix this bug
B0pol
changed the title
see TeamNewPipe#2921 (comment) It will add Esperanto, add bengali, update vietnamese pretty time is the library used in the home page: … days ago
3 tasks
TobiGr
reviewed
Jan 28, 2020
app/src/main/res/values/strings.xml
Outdated
| @@ -589,4 +587,11 @@ | |||
| <string name="downloads_storage_use_saf_title">Use SAF</string> | |||
| <string name="downloads_storage_use_saf_summary">The Storage Access Framework allows downloads to an external SD card.\nNote: some devices are not compatible</string> | |||
| <string name="choose_instance_prompt">Choose an instance</string> | |||
| <string name="videos_fixed">Videos</string> | |||
| <string name="five_seconds">5 seconds</string> | |||
There was a problem hiding this comment.
Wouldn't be %s seconds better here? We would need to add the seek_duration_description items dynamically, but this shouldn't be a problem.
There was a problem hiding this comment.
I firstly done that, but there is a problem: summary is now fine, but when you click on the list, it only shows the value (eg 5, 10, 15…), but not seconds anymore.
(I made this with the last commit)
renamed NewPipe's language into App language, and same for all the concerning thing (keys, comments…) we now call assureCorrectAppLanguage(CONTEXT) in activities needing it instead of changeAppLanguage(getAppLocale(CONTEXT), RESOURCES) changeAppLanguage becomes private.
Changed android.R.string.ok, which is "OK", into R.string.finish, which is also OK, but from our strings Then for a small amount of languages that don't have Android translation, it will show the good string.
I forgot to change the key here when I renamed it
|
I'm closing this pr as commits are screwed up (I merged locally instead of with github) and I don't know how to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3025