Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose theme improvements #11539

Merged

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Sep 16, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Implement black theme in Compose.
  • Update the Compose theme colors with ones generated using the Material Theme Builder. This new theme follows the Material 3 guidelines.
  • Update the background colors in the existing app theme to match the Compose theme.

Before/After Screenshots/Screen Record

Before Before
Before Before
After After
After After

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Sep 16, 2024
@AudricV AudricV added the GUI Issue is related to the graphical user interface label Sep 16, 2024
@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 5, 2024
# Conflicts:
#	app/src/main/java/org/schabi/newpipe/fragments/list/videos/RelatedItemsFragment.kt
#	app/src/main/java/org/schabi/newpipe/ui/components/items/ItemList.kt
# Conflicts:
#	app/src/main/java/org/schabi/newpipe/ui/components/common/NoItemsMessage.kt
#	app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentRepliesDialog.kt
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TeamNewPipe TeamNewPipe deleted a comment from sonarqubecloud bot Jan 28, 2025
@TeamNewPipe TeamNewPipe deleted a comment from sonarqubecloud bot Jan 28, 2025
@Stypox Stypox merged commit 407d2d7 into TeamNewPipe:refactor Jan 28, 2025
7 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Compose-theme-improvements branch January 31, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite size/large PRs with less than 750 changed lines
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants