Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CommentTextOnTouchListener to a lambda #11075

Merged

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Convert the CommentTextOnTouchListener class to a lambda in CommentInfoItemHolder.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label May 15, 2024
Copy link

@Isira-Seneviratne Isira-Seneviratne merged commit 3e3d1fd into TeamNewPipe:dev May 25, 2024
7 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Comment-touch-lambda branch May 25, 2024 23:04
@AudricV AudricV changed the title Convert comment touch listener to a lambda Convert CommentTextOnTouchListener to a lambda Jul 4, 2024
@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Jul 4, 2024
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality size/medium PRs with less than 250 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants