Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Download] Fix audio stream selection #10230

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jul 14, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes a regression introduced by #9937 that made the DownloadDialog not respect the selected audio stream but download the initially selected stream.

Fixes the following issue(s)

Fixes #10180

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Jul 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit 43ef852 into dev Jul 17, 2023
@TobiGr TobiGr deleted the fix/offline-stream-chooser branch July 18, 2023 23:26
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[nightly] Downloader: audio stream selection does not work
3 participants