Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [CHORE] 프로필 수정 뷰 정상화 #584

Merged
merged 9 commits into from
Oct 26, 2022
Merged

✅ [CHORE] 프로필 수정 뷰 정상화 #584

merged 9 commits into from
Oct 26, 2022

Conversation

dev-jungbin
Copy link
Member

🍎 관련 이슈

closed #580

🍎 변경 사항 및 이유

  • 기존 코드 리팩토링(데이터 비교 및 저장 버튼 활성화 부분)
  • 바텀시트 변경(HalfModalView -> SignUpModalVC)
  • 프로필 수정 api 코드 수정

🍎 PR Point

  • 없슴다

📸 ScreenShot

RPReplay_Final1666765632.mov

@dev-jungbin dev-jungbin added ❤️ 정빈걸 ❤️ 정빈이 연 pr, issue에 사용 🙋🏻‍♀️ 마이페이지탭 마이페이지탭 개발시 사용합니다. ✅ Chore 자잘한 수정 시 사용합니다. 🛠 QA QA 반영시 사용합니다. labels Oct 26, 2022
@dev-jungbin dev-jungbin self-assigned this Oct 26, 2022
hwangJi-dev
hwangJi-dev approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인~!!!

@dev-jungbin dev-jungbin merged commit a4a56c8 into develop Oct 26, 2022
@dev-jungbin dev-jungbin deleted the chore/#580-EditProfile branch October 26, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangJi-dev hwangJi-dev hwangJi-dev approved these changes

@jane1choi jane1choi Awaiting requested review from jane1choi

Assignees

@dev-jungbin dev-jungbin

Labels
✅ Chore 자잘한 수정 시 사용합니다. ❤️ 정빈걸 ❤️ 정빈이 연 pr, issue에 사용 🙋🏻‍♀️ 마이페이지탭 마이페이지탭 개발시 사용합니다. 🛠 QA QA 반영시 사용합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ [CHORE] 프로필 수정 뷰 정상화
2 participants
@dev-jungbin @hwangJi-dev