✨ [FEAT] 홈 API 연결 #470
Merged
✨ [FEAT] 홈 API 연결 #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jungbin
added
📡 Network
hwangJi-dev
reviewed
Sep 25, 2022
| @@ -70,6 +70,7 @@ extension BaseVC { | |||
| UserDefaults.standard.set(data.user.secondMajorID, forKey: UserDefaults.Keys.SecondMajorID) | |||
| UserDefaults.standard.set(data.user.secondMajorName, forKey: UserDefaults.Keys.SecondMajorName) | |||
| UserDefaults.standard.set(data.user.userID, forKey: UserDefaults.Keys.UserID) | |||
| UserDefaults.standard.set(data.user.universityID, forKey: UserDefaults.Keys.univID) | |||
|
@hwangJi-dev 및힌 저거 보고 수정해서 고쳤어 곰마워!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
jane1choi
approved these changes
Sep 25, 2022
Comment on lines
+37
to
+67
| /// [GET] 학교 후기 전체 최신순 조회 | ||
| func getAllReviewList(completion: @escaping (NetworkResult<Any>) -> (Void)) { | ||
| provider.request(.getAllReviewList) { result in | ||
| switch result { | ||
| case .success(let response): | ||
| let statusCode = response.statusCode | ||
| let data = response.data | ||
|
|
||
| let networkResult = self.judgeStatus(by: statusCode, data, HomeRecentReviewResponseData.self) | ||
| completion(networkResult) | ||
|
|
||
| case .failure(let err): | ||
| print(err.localizedDescription) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// [GET] 선배 랭킹 조회 | ||
| func getUserRankingList(completion: @escaping (NetworkResult<Any>) -> (Void)) { | ||
| provider.request(.getUserRankingList) { result in | ||
| switch result { | ||
| case .success(let response): | ||
| let statusCode = response.statusCode | ||
| let data = response.data | ||
|
|
||
| let networkResult = self.judgeStatus(by: statusCode, data, HomeRankingResponseModel.self) | ||
| completion(networkResult) | ||
|
|
||
| case .failure(let err): | ||
| print(err.localizedDescription) | ||
| } |
Comment on lines
+39
to
+42
| override func prepareForReuse() { | ||
| super.prepareForReuse() | ||
| updateRecentPostTVHeight() | ||
| } |
Comment on lines
+53
to
+59
| func updateRecentPostTVHeight() { | ||
| self.recentPostTV.reloadData() | ||
| self.recentPostTV.snp.updateConstraints { | ||
| $0.height.equalTo(self.recentPostTV.contentSize.height) | ||
| } | ||
| self.recentPostTV.layoutIfNeeded() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍎 관련 이슈
closed #463
🍎 변경 사항 및 이유
🍎 PR Point
📸 ScreenShot
RPReplay_Final1664086768.mov