Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”จ [CHORE] ์ฝ”์ฝ”์•„ํŒŸ ์˜์กด์„ฑ ์ œ๊ฑฐ ๋ฐ SPM์œผ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ #417

Merged
merged 4 commits into from
Aug 5, 2022
Merged

๐Ÿ”จ [CHORE] ์ฝ”์ฝ”์•„ํŒŸ ์˜์กด์„ฑ ์ œ๊ฑฐ ๋ฐ SPM์œผ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ #417

merged 4 commits into from
Aug 5, 2022

Conversation

dev-jungbin
Copy link
Member 

- commit message๊ฐ€ ์ ์ ˆํ•œ์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- ๋งˆ์ง€๋ง‰์œผ๋กœ Coding Convention์„ ์ค€์ˆ˜ํ–ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- ์ ์ ˆํ•œ branch๋กœ ์š”์ฒญํ–ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.
- Assignees, Label์„ ๋ถ™์—ฌ์ฃผ์„ธ์š”.
- ๊ฐ€๋Šฅํ•œ ์ด์Šˆ๋ฅผ Link ํ•ด์ฃผ์„ธ์š”.
- PR์ด ์Šน์ธ๋œ ๊ฒฝ์šฐ ํ•ด๋‹น ๋ธŒ๋žœ์น˜๋Š” ์‚ญ์ œ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐ŸŽ ๊ด€๋ จ ์ด์Šˆ

closed #416

๐ŸŽ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋ฐ ์ด์œ 

  • ์ฝ”์ฝ”์•„ํŒŸ ๊ด€๋ จ ํŒŒ์ผ์„ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • Moya, Snapkit, Then์„ Package๋กœ ์„ค์น˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐ŸŽ PR Point

  • ๋””๋ฒจ๋กญ์—์„œ pull ๋ฐ›๊ณ  ํ™•์ธ ํ•œ ๋ฒˆ๋งŒ ํ•ด ์ฃผ์„ธ์š”์˜ค์˜ค์˜ค์˜ค์˜น

๐Ÿ“ธ ScreenShot

๊น”๋”ํ•ด์ง„ ํ”„๋กœ์ ํŠธ ํด๋”!!

image

@dev-jungbin dev-jungbin added โค๏ธ ์ •๋นˆ๊ฑธ โค๏ธ ์ •๋นˆ์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ โœ… Chore ์ž์ž˜ํ•œ ์ˆ˜์ • ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. labels Aug 4, 2022
@dev-jungbin dev-jungbin requested a review from hwangJi-dev August 4, 2022 16:54
@dev-jungbin dev-jungbin self-assigned this Aug 4, 2022
jane1choi
jane1choi approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ,,๊ณ ๋งˆ์›ก ์ˆ˜๊ณ ํ•ด์จโค๏ธโ€๐Ÿ”ฅ

@dev-jungbin dev-jungbin changed the title Chore/#416 remove pods install spm ๐Ÿ”จ [CHORE] ์ฝ”์ฝ”์•„ํŒŸ ์˜์กด์„ฑ ์ œ๊ฑฐ ๋ฐ SPM์œผ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ Aug 5, 2022
hwangJi-dev
hwangJi-dev approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •๋น„๋‹ˆ์งฑ! workspace ์•„๋‹Œ ํ™˜๊ฒฝ ์ฉœ ๋‚ฏ์„ค๋‹ค..~ ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹

@dev-jungbin dev-jungbin merged commit 0c939c5 into develop Aug 5, 2022
@dev-jungbin dev-jungbin deleted the chore/#416-RemovePods-InstallSPM branch August 5, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane1choi jane1choi jane1choi approved these changes

@hwangJi-dev hwangJi-dev hwangJi-dev approved these changes

Assignees

@dev-jungbin dev-jungbin

Labels
โœ… Chore ์ž์ž˜ํ•œ ์ˆ˜์ • ์‹œ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. โค๏ธ ์ •๋นˆ๊ฑธ โค๏ธ ์ •๋นˆ์ด ์—ฐ pr, issue์— ์‚ฌ์šฉ
Projects
None yet
Milestone
No milestone
3 participants
@dev-jungbin @hwangJi-dev @jane1choi