Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”¨ [FIX] ν˜„μž¬ μ•± 버전 쑰회 버그 μˆ˜μ • #394

Merged
merged 2 commits into from
Mar 26, 2022
Merged

πŸ”¨ [FIX] ν˜„μž¬ μ•± 버전 쑰회 버그 μˆ˜μ • #394

merged 2 commits into from
Mar 26, 2022

Conversation

hwangJi-dev
Copy link
Member

🍎 κ΄€λ ¨ 이슈

closed #393

🍎 λ³€κ²½ 사항 및 이유

  • AppVersion의 currentVersion λ³€μˆ˜μ˜ 값을 Info의 μ•± λ²„μ „μœΌλ‘œ λ³€κ²½ν•΄μ£Όμ—ˆμŠ΅λ‹ˆλ‹€.

🍎 PR Point

  • ν˜„μž¬ μ•± 버전 쑰회 버그 μˆ˜μ •!!

πŸ“Έ ScreenShot

@hwangJi-dev hwangJi-dev added 🐞 Bug 예기치 μ•Šμ€ 문제 λ˜λŠ” μ˜λ„ν•˜μ§€ μ•Šμ€ λ™μž‘(버그) λ°œμƒ μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. ⚑️ HotFix κΈ‰ν•œ μˆ˜μ •μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. βœ¨πŸ• Jieun 🐰✨ 지은이 μ—° pr, issue에 μ‚¬μš© πŸ›  QA QA λ°˜μ˜μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. labels Mar 26, 2022
@hwangJi-dev hwangJi-dev requested a review from dev-jungbin March 26, 2022 14:00
@hwangJi-dev hwangJi-dev self-assigned this Mar 26, 2022
dev-jungbin
dev-jungbin approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš°μ™• 이거 μ§„μ§œ μ‹ κΈ°ν•˜λ„€μ—¬
μ—­μ‹œ μ²œμž¬λ¦¬λ“œ!!

jane1choi
jane1choi approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! 싱글톀 μ—…μ‹œ λͺ»μ‚΄μ•„ 정말 λͺ»μ‚΄μ•„~짝!

NadoSunbae-iOS/NadoSunbae-iOS/Global/PublicData/Singleton/AppVersion.swift
@@ -13,7 +13,7 @@ class AppVersion {
static let shared = AppVersion()

var latestVersion = ""
var currentVersion = "1.0.0"
var currentVersion = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™• 체고닀!! 확인이여~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

싱글톀 μ—…μ‹œ λͺ»μ‚΄μ•„ 정말 λͺ»μ‚΄μ•„λž˜ γ…‹γ…‹γ…‹γ…‹γ…‹γ…‹

@hwangJi-dev hwangJi-dev merged commit 2897697 into develop Mar 26, 2022
@hwangJi-dev hwangJi-dev deleted the fix/#393-Hotfix-GetCurrentAppVersion branch March 26, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jane1choi jane1choi jane1choi approved these changes

@dev-jungbin dev-jungbin dev-jungbin approved these changes

Assignees

@hwangJi-dev hwangJi-dev

Labels
🐞 Bug 예기치 μ•Šμ€ 문제 λ˜λŠ” μ˜λ„ν•˜μ§€ μ•Šμ€ λ™μž‘(버그) λ°œμƒ μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. ⚑️ HotFix κΈ‰ν•œ μˆ˜μ •μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. βœ¨πŸ• Jieun 🐰✨ 지은이 μ—° pr, issue에 μ‚¬μš© πŸ›  QA QA λ°˜μ˜μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ”¨Β [FIX] ν˜„μž¬ μ•± 버전 쑰회 버그 μˆ˜μ •
3 participants
@hwangJi-dev @dev-jungbin @jane1choi