Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”¨ [FIX] ν›„κΈ° 상세 λ·° ν”„λ‘œν•„μ— ν•™κ³Ό μ§„μž… μ‹œκΈ° ν‘œμ‹œ #381

Merged
merged 2 commits into from
Mar 20, 2022
Merged

πŸ”¨ [FIX] ν›„κΈ° 상세 λ·° ν”„λ‘œν•„μ— ν•™κ³Ό μ§„μž… μ‹œκΈ° ν‘œμ‹œ #381

merged 2 commits into from
Mar 20, 2022

Conversation

jane1choi
Copy link
Member

🍎 κ΄€λ ¨ 이슈

closed #376

🍎 λ³€κ²½ 사항 및 이유

  • ν›„κΈ° 상세 λ·° ν”„λ‘œν•„μ— ν•™κ³Ό μ§„μž… μ‹œκΈ°κ°€ λˆ„λ½λ˜μ—ˆλ˜ 문제λ₯Ό ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.

🍎 PR Point

  • 본전곡이 μ •λ³΄μ—†μŒμΈ 경우, 제2전곡이 λ―Έμ§„μž…μΈ κ²½μš°μ—λŠ” μ§„μž…μ‹œκΈ°κ°€ ν‘œμ‹œλ˜μ§€ μ•Šλ„λ‘ λΆ„κΈ°μ²˜λ¦¬λ₯Ό ν•΄μ£Όμ—ˆμŠ΅λ‹ˆλ‹€.
  • 학과이름이 κΈ΄ 경우 ...으둜 ν‘œμ‹œλ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€.(ν”„λ‘œν•„ ν΄λ¦­μ‹œ λ°”λ‘œ 확인할 수 있기 λ•Œλ¬Έ)

πŸ“Έ ScreenShot

μŠ€ν¬λ¦°μƒ· 2022-03-05 μ˜€ν›„ 6 57 37 μŠ€ν¬λ¦°μƒ· 2022-03-05 μ˜€ν›„ 6 57 37
μŠ€ν¬λ¦°μƒ· 2022-03-05 μ˜€ν›„ 6 57 37

@jane1choi jane1choi added πŸ“± View λ·° 개발(λ””μžμ΄λ‹)μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. 🏠 ν›„κΈ°νƒ­ ν›„κΈ° νƒ­ κ°œλ°œμ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. πŸ’œ 은주 πŸ’œ 은주가 μ—° pr, issue에 μ‚¬μš© βœ… Chore μžμž˜ν•œ μˆ˜μ • μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. πŸ›  QA QA λ°˜μ˜μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. labels Mar 19, 2022
@jane1choi jane1choi requested a review from hwangJi-dev March 19, 2022 18:34
@jane1choi jane1choi self-assigned this Mar 19, 2022
hwangJi-dev
hwangJi-dev approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈμ΄μš”!

dev-jungbin
dev-jungbin approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅Ώ~!

@jane1choi jane1choi merged commit 5052467 into develop Mar 20, 2022
@jane1choi jane1choi deleted the fix/#376-UI-ReviewDetail-Profile branch March 20, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangJi-dev hwangJi-dev hwangJi-dev approved these changes

@dev-jungbin dev-jungbin dev-jungbin approved these changes

Assignees

@jane1choi jane1choi

Labels
βœ… Chore μžμž˜ν•œ μˆ˜μ • μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. 🏠 ν›„κΈ°νƒ­ ν›„κΈ° νƒ­ κ°œλ°œμ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. πŸ’œ 은주 πŸ’œ 은주가 μ—° pr, issue에 μ‚¬μš© πŸ›  QA QA λ°˜μ˜μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€. πŸ“± View λ·° 개발(λ””μžμ΄λ‹)μ‹œ μ‚¬μš©ν•©λ‹ˆλ‹€.
Projects
None yet
Milestone
No milestone
3 participants
@jane1choi @dev-jungbin @hwangJi-dev