Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [CHORE] BaseQuestionTVC관련 중복 파일을 제거하고 TVC를 통일합니다. #542

Closed
3 tasks done
hwangJi-dev opened this issue Oct 16, 2022 · 0 comments · Fixed by #544
Closed
3 tasks done

✅ [CHORE] BaseQuestionTVC관련 중복 파일을 제거하고 TVC를 통일합니다. #542

hwangJi-dev opened this issue Oct 16, 2022 · 0 comments · Fixed by #544
Assignees
@hwangJi-dev
Labels
✅ Chore 자잘한 수정 시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 💡 Refactor 코드 리펙토링 시 사용합니다.

Comments

@hwangJi-dev
Copy link
Member

hwangJi-dev commented Oct 16, 2022 •
edited
Loading

🙋🏻 Feature Issue

  • QuestionTVC관련 중복 파일을 제거하고 TVC를 통일합니다.

🙋🏻 작업 브랜치

📝 To-do

  • BaseQuestionTVC관련 중복 파일 제거 (EntireQuestionTVC, QuestionTVC 등)
  • BaseQuestionTVC로 코드 통일
  • EntireQuestionTVC로 사용하던 코드들 TableView에 top inset 추가하기
@hwangJi-dev hwangJi-dev added 💡 Refactor 코드 리펙토링 시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 ✅ Chore 자잘한 수정 시 사용합니다. labels Oct 16, 2022
@hwangJi-dev hwangJi-dev self-assigned this Oct 16, 2022
hwangJi-dev added a commit that referenced this issue Oct 16, 2022
@hwangJi-dev
⚰️ Remove: 필요하지 않은 파일 삭제 (#542)
f700ff9
hwangJi-dev added a commit that referenced this issue Oct 16, 2022
@hwangJi-dev
🚚 Move: 파일 이동 (#542)
24cb7e1
hwangJi-dev added a commit that referenced this issue Oct 16, 2022
@hwangJi-dev
✅ Chore: 초기화 단계에서 BaseQuestionTVC의 UI 구현부 호출을 제거하고 함수로 분리 및 파일 위치 이동 (#…
9332ebb 
…542)
hwangJi-dev added a commit that referenced this issue Oct 16, 2022
@hwangJi-dev
✅ Chore: 1:1 질문 관련 TVC 코드들 BaseQuestionTVC로 통일 (#542)
574da06
hwangJi-dev added a commit that referenced this issue Oct 16, 2022
@hwangJi-dev
✅ Chore: 기존 TVC를 EntireQuestionTVC로 사용하던 TableView에 top inset 추가 (#542)
0885eab
@hwangJi-dev hwangJi-dev mentioned this issue Oct 16, 2022
Merged
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
⚰️ Remove: 필요하지 않은 파일 삭제 (#542)
90cbab1
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
🚚 Move: 파일 이동 (#542)
30d6712
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
✅ Chore: 초기화 단계에서 BaseQuestionTVC의 UI 구현부 호출을 제거하고 함수로 분리 및 파일 위치 이동 (#…
f32217f 
…542)
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
✅ Chore: 1:1 질문 관련 TVC 코드들 BaseQuestionTVC로 통일 (#542)
c5bb58c
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
✅ Chore: 기존 TVC를 EntireQuestionTVC로 사용하던 TableView에 top inset 추가 (#542)
2432cc1
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
✅ Chore: Rebase 후 없어진 파일 추가 및 코드 수정 (#542)
b540b8c
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
Merge remote-tracking branch 'origin/chore/#542-baseQuestionTVC-remov…
74b6c8e 
…eDuplicate' into chore/#542-baseQuestionTVC-removeDuplicate
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
✅ Chore: 머지 confilct 해결 (#542)
581a8a4
hwangJi-dev added a commit that referenced this issue Oct 19, 2022
@hwangJi-dev
Merge pull request #544 from TeamNado-Sunbae/chore/#542-baseQuestionT…
2f75ef2 
…VC-removeDuplicate

✅ [CHORE] BaseQuestionTVC관련 중복 파일을 제거하고 TVC를 통일합니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwangJi-dev hwangJi-dev

Labels
✅ Chore 자잘한 수정 시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 💡 Refactor 코드 리펙토링 시 사용합니다.
Projects
None yet
Milestone
No milestone
1 participant
@hwangJi-dev