-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity 세팅 #11
Entity 세팅 #11
Conversation
oownahcohc
commented
Nov 18, 2023
- Entity 세팅 #7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확실하지 않은 부분에 코멘트 남겨뒀어요! 🙂
fillin/src/main/java/com/teamfillin/fillin/domain/photo/Status.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/price/Price.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/account/SocialInfo.java
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/photo/Photo.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/reactionHistory/TargetType.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 전체적으로 기본 생성자를 protected 로 제한하셨는데 이유가 있으실까요? (private 으로 하는건 어떠실까요~?)
- BaseEntity 만들어서 AuditingEntityListener 상속하면 좋을것같습니다 😄
fillin/src/main/java/com/teamfillin/fillin/domain/account/SocialInfo.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/account/SocialInfo.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/account/Account.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/user/Status.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/photo/Photo.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/photo/Status.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/reactionHistory/ReactionHistory.java
Outdated
Show resolved
Hide resolved
fillin/src/main/java/com/teamfillin/fillin/domain/reactionHistory/TargetType.java
Show resolved
Hide resolved
모든 엔티티에 사용될 것 같지 않아서 별개로 적용했는데, BaseEntity 로 만들어서 상속하는게 관리가 더 편할까요?! |
오.. 맞네요..! 확인 감사합니다 :)
음 일괄적으로 적용할 수 있을것같아서요, createdAt, updatedAt 이 적용되어지는 엔티티들에 대해서는 모두 적용하면 좋을것같습니다~! |