[WIP] Units Library #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayang
reviewed
Feb 1, 2020
build.gradle
Outdated
| // or from command line. If not found an exception will be thrown. | ||
| // You can use getTeamOrDefault(team) instead of getTeamNumber if you | ||
| // want to store a team number in this file. | ||
| team = frc.getTeamNumber() |
There was a problem hiding this comment.
We can't change this because it's setting a property that's used by the Gradle plugin we use
|
|
||
| // ramsete constants (tested for most robots) | ||
| public static final double kB = 2.0; | ||
| public static final double kZeta = 0.7; | ||
| } | ||
|
|
| public static final Trajectory TEST_TRAJECTORY = | ||
| TrajectoryGenerator.generateTrajectory( | ||
| new Pose2d(0, 0, new Rotation2d(0)), | ||
| List.of( |
src/main/java/org/team4159/frc/robot/subsystems/Drivetrain.java
Outdated
Show resolved
Hide resolved
src/main/java/org/team4159/frc/robot/subsystems/Drivetrain.java
Outdated
Show resolved
Hide resolved
| }); | ||
| StringBuilder name = new StringBuilder(); | ||
| boolean slashed = false; | ||
| for (int i = sorted_units.size() - 1; i >= 0; i--) { |
There was a problem hiding this comment.
Need some newlines in the mehtod to organize the code better
| @Override | ||
| public String symbol() { | ||
| ArrayList<Map.Entry<Unit, Integer>> sorted_units = new ArrayList<>(getUnits().entrySet()); | ||
| sorted_units.sort((a, b) -> { |
There was a problem hiding this comment.
Seperate this into another function and pass that function into the sort
|
|
||
| @Override | ||
| public String toString() { | ||
| return amount + " " + unit.symbol(); |
There was a problem hiding this comment.
Does Java automatically convert doubles to string when concatenating with string?
|
do we still want to merge this, or should i close the pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lot of utilities to the library
DONT MERGE