Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 온보딩 dto 관련 버그 수정 #44

Merged
merged 5 commits into from
Jul 15, 2023
Merged

[FIX] 온보딩 dto 관련 버그 수정 #44

merged 5 commits into from
Jul 15, 2023

Conversation

ddongseop
Copy link
Member

@ddongseop ddongseop commented Jul 15, 2023 •
edited
Loading

📌 관련 이슈

�closed #43

✨ 어떤 이유로 변경된 내용인지

  • DB에 live_together 필드가 남아 있는 것 해결
  • 푸시 알림 시간이 "23:00:00" 형식으로 리턴되는 것 "23:00"으로 리턴되게 수정
  • YES, NO가 아니라 응, 아니로 선택질문 답변 받도록 수정
  • 온보딩 정보 입력 (초대받는 측) API에서 parentchild_id 빠지게 변경
  • API 명세서에 수정사항 반영
  • snake_case로만 받아지는거 수정
  • 과거의 문답 리스트 조회하기 질문이 아니라 주제 보여주는걸로 변경

🙏 검토 혹은 리뷰어에게 남기고 싶은 말

@ddongseop ddongseop added 🔥 Pull Request PR 날림 🚨Hotfix 급한 수정사항 발생 ddongseop🍑 🪄API 서버 API 통신 ☁️Database DB 관련 labels Jul 15, 2023
@ddongseop ddongseop requested a review from jun02160 July 15, 2023 09:09
@ddongseop ddongseop self-assigned this Jul 15, 2023
jun02160
jun02160 approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@jun02160 jun02160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 짱이다.. 수고했어 👍

@ddongseop ddongseop merged commit 4796c6b into develop Jul 15, 2023
@ddongseop ddongseop deleted the fix/#43-change_onboard_dto branch August 12, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jun02160 jun02160 jun02160 approved these changes

Assignees

@ddongseop ddongseop

Labels
🪄API 서버 API 통신 ☁️Database DB 관련 ddongseop🍑 🚨Hotfix 급한 수정사항 발생 🔥 Pull Request PR 날림
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 온보딩 dto 관련 버그 수정
2 participants
@ddongseop @jun02160