[FEAT] 홈 화면 관련 API #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddongseop
approved these changes
Jul 11, 2023
| @@ -14,7 +14,7 @@ | |||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | |||
| @AllArgsConstructor(access = AccessLevel.PROTECTED) | |||
| @Builder | |||
| public class User extends AuditingTimeEntity { | |||
| public class User extends AuditingTimeEntity { | |||
Comment on lines
+171
to
+177
| public GetInviteCodeResponseDto getInvitation(Long userId) { | ||
|
|
||
| Parentchild parentchild = parentchildDao.findByUserId(userId); | ||
|
|
||
| return GetInviteCodeResponseDto.of(parentchild); | ||
| } | ||
|
|
There was a problem hiding this comment.
지금 두 API가 2개의 Service에 나눠져 있구, 1개의 Controller에서 호출되고 있어가지구!
이거 어떻게 할지 회의좀 해봐야겠다!
| @@ -67,4 +71,19 @@ public ApiResponse<SingleQnAResponseDto> getSingleQna( | |||
| return ApiResponse.success(SuccessType.GET_SINGLE_QNA_SUCCESS, | |||
| qnAService.getSingleQna(JwtProvider.getUserFromPrincial(principal), qnaId)); | |||
| } | |||
|
|
|||
| // TODO HomeController로 따로 뺄지? | |||
|
|
||
| @Slf4j | ||
| @Repository | ||
| public class QnADao { |
There was a problem hiding this comment.
기존에 있던 것도 이런식으로 참고해서 리팩토링 진행할게!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
close #18
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말