[FEAT] 온보딩 부모자식 관계 정보 입력(초대하는 측) API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jun02160
added
🔥 Pull Request
ddongseop
approved these changes
Jul 9, 2023
|
|
||
| private String relationInfo; // 아들 or 딸 | 아빠 or 엄마 | ||
|
|
||
| // TODO 디폴트 값 지정해줘야 할까? -> by 디폴트 생성자 |
There was a problem hiding this comment.
클라쪽에서 기본적으로 23시로 설정 가능하다고 함!
따라서 그냥 넘어오는 값으로 세팅해주기 :)
| private String relationInfo; // 아들 or 딸 | 아빠 or 엄마 | ||
|
|
||
| // TODO 디폴트 값 지정해줘야 할까? -> by 디폴트 생성자 | ||
| @JsonFormat(pattern = "kk:mm") |
Comment on lines
+30
to
+31
| // @Column(nullable = false) | ||
| private boolean isInvitorChild; |
There was a problem hiding this comment.
P1: 이부분 nullable false로 바꿔도 될듯! 어짜피 이제 한번에 넘어오니까
| @Column(nullable = false) | ||
| private LocalTime pushTime; | ||
| @Column(nullable = false) // TODO 푸시알림 시간 디폴트 값 없으면 nullable: true로 변경 | ||
| private LocalTime pushTime; // default: 오후 11시 |
There was a problem hiding this comment.
위에서 말한 것처럼 디폴트값 클라에서 고려해서 넘어옴!
| @Slf4j | ||
| @Service | ||
| @RequiredArgsConstructor | ||
| @Transactional(readOnly = true) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
close #13
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말