[CHORE] 환경 분리를 위한 yml 파일 변경 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddongseop
added
🔥 Pull Request
jun02160
approved these changes
Sep 24, 2023
Comment on lines
+45
to
+54
| # 3) AWS Secrets Manger 환경변수 사용 | ||
| - name: Read secrets from AWS Secrets Manager into environment variables | ||
| uses: abhilash1in/[email protected] | ||
| with: | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY }} | ||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_KEY }} | ||
| aws-region: ap-northeast-2 | ||
| secrets: /secret/umbba-dev | ||
| parse-json: false | ||
|
|
Comment on lines
+40
to
+80
| cloud: | ||
| aws: | ||
| credentials: | ||
| accessKey: ${CLOUD_ACCESS} | ||
| secretKey: ${CLOUD_SECRET} | ||
| region: | ||
| static: ${CLOUD_REGION} | ||
| s3: | ||
| bucket: ${BUCKET_NAME} | ||
| stack: | ||
| auto: false | ||
| sqs: | ||
| notification: | ||
| name: ${SQS_NOTIFICATION_NAME} | ||
| url: ${SQS_NOTIFICATION_URL} | ||
|
|
||
| kakao: | ||
| client-id: ${KAKAO_ID} | ||
| authorization-grant-type: authorization_code | ||
| redirect-uri: ${KAKAO_REDIRECT} | ||
| apple: | ||
| iss: ${APPLE_ISS} | ||
| client-id: ${APPLE_ID} | ||
| # nonce: | ||
|
|
||
| jwt: | ||
| secret: ${JWT_SECRET} | ||
|
|
||
| slack: | ||
| webhook: | ||
| url: ${SLACK_URL} | ||
|
|
||
| fcm: | ||
| key: | ||
| path: ${FCM_JSON_PATH} | ||
| scope: ${FCM_SCOPE} | ||
| # firebase-create-scoped: "https://www.googleapis.com/auth/firebase.messaging" | ||
| api: | ||
| url: ${FCM_API_URL} | ||
| topic: | ||
| "qna_notification" |
Comment on lines
+88
to
+135
|
|
||
| # local_setting | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local_setting | ||
|
|
||
| server: | ||
| port: 9091 | ||
|
|
||
| # local_notification_setting | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local_notification_setting | ||
|
|
||
| server: | ||
| port: 9092 | ||
|
|
||
| # set1_setting | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: set1_setting | ||
|
|
||
| server: | ||
| port: 8081 | ||
|
|
||
| # set2_setting | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: set2_setting | ||
|
|
||
| server: | ||
| port: 8082 | ||
|
|
||
| # notification_setting | ||
| --- | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: notification_setting | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#105
✨ 어떤 이유로 변경된 내용인지
환경 분리를 위해 로컬 환경과 배포 서버에서 사용하는 yml 형식을 통일하였음
해당 yml 파일은 로컬 환경과 배포 서버에서 모두 사용할 수 있으며,
어떤 환경 변수를 넣어주는지와 active profile에 따라서 환경이 분리될 것임
로컬 환경에서는 Intellij의 설정을 통해 환경변수에 값을 넣어줄 것이며,
배포 서버에서는 AWS Secret Manager을 통해 환경변수에 값을 넣어주는 원리
(기존에 yaml파일을 아예 생성해줬던 것에서 변경)
🙏 검토 혹은 리뷰어에게 남기고 싶은 말