Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback on commit #341

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Rollback on commit #341

merged 1 commit into from
Jan 6, 2024

Conversation

CodeRedDev
Copy link
Contributor

Removes the unnecessary and bug triggering check for .js postfix on plugin property from config

Fixes #338

@werewolfboy13
Copy link
Collaborator

Not approving PR unless supporting documentation is given.

@CodeRedDev
Copy link
Contributor Author

@Zer0-1ne put the check this PR is removing here by accident and unfortunately did not remove them in his latest commits.

The check here inside factory.js does not check against file identifiers it check against the plugin properties of the plugins inside config.json and as they are never having a .js postfix, non of the plugins will be added to the servers plugins list and non will be mounted.

@CodeRedDev CodeRedDev mentioned this pull request Jan 6, 2024
Closed
@werewolfboy13 werewolfboy13 changed the title Removing unnecessary check for .js postfix Rollback on commit #UNKNOWN Jan 6, 2024
@werewolfboy13 werewolfboy13 changed the title Rollback on commit #UNKNOWN Rollback on commit Jan 6, 2024
@werewolfboy13 werewolfboy13 added the core bug Bug related to the core SquadJS API label Jan 6, 2024
@werewolfboy13
Copy link
Collaborator

Apologies, I see what is going here. My IDE was not loading this PR correctly. Pushing for approval.

@werewolfboy13 werewolfboy13 merged commit 8bfeb4d into Team-Silver-Sphere:master Jan 6, 2024
@werewolfboy13
Copy link
Collaborator

@Zer0-1ne I will need you to double check your other commits to make sure its placed correctly when able.

@Zer0-1ne
Copy link
Contributor

Zer0-1ne commented Jan 7, 2024

I seriously dont understand why it worked beforehand, but I've checked and its in the correct place, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core bug Bug related to the core SquadJS API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS file check breaks application
3 participants
@CodeRedDev @werewolfboy13 @Zer0-1ne