Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network [#89] 챌린지 관련 서버 통신 #92

Merged
merged 14 commits into from
Jan 16, 2024
Merged

Conversation

Zoe0929
Copy link
Member

@Zoe0929 Zoe0929 commented Jan 15, 2024

👾 작업 내용

  • 온보딩의 앱 추가 버튼을 연결했습니다.
  • 챌린지 전체 서버 통신을 완료했습니다.

🚀 PR Point

  • 서버 통신시, Request Body가 비어 있는 경우를 처리하기 위해 EmptyRequestDTO를 만들어 처리했습니다.
  • 온보딩의 전체적인 플로우를 연결했습니다. 하지만 회원가입 서버 통신 오류 시 처리를 조금 더 고민해볼 예정입니다.
    let provider = Providers.AuthProvider
    provider.request(target: .signUp(data: request), instance: BaseResponse<SignUpResponseDTO>.self, viewController: self) { data in
    if data.status == 201 {
    self.setRootViewController(SignInCompleteViewController())
    guard let data = data.data else { return }
    UserManager.shared.updateToken(data.token.accessToken, data.token.refreshToken)
    UserManager.shared.updateUserId(data.userId)
    } else {

📸 스크린샷

구현 내용 스크린샷
온보딩 뷰 파일첨부바람

✅ Issue

Resolved #89

@Zoe0929 Zoe0929 added 🐰지희 지희의 issue 🌈 feat 기능 구현 📡 network api 작업 labels Jan 15, 2024
@Zoe0929 Zoe0929 added this to the 🚀1차 스프린트🚀 milestone Jan 15, 2024
@Zoe0929 Zoe0929 self-assigned this Jan 15, 2024
@Zoe0929 Zoe0929 linked an issue Jan 15, 2024 that may be closed by this pull request
Copy link
Member

@kim-seonwoo kim-seonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!~🙏

Comment on lines +88 to +89
case .getdailyChallenge:
return .requestPlain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 그냥 dailyChallenge인 네이밍 어떤가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오옹 약간 Get Method인걸 알려주기 위해 붙여뒀는데 그게 더 나을까요 ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실 문제 될건 없을 것 같습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저히 get, set 지양티비~

@Zoe0929 Zoe0929 merged commit ab896f6 into develop Jan 16, 2024
@Zoe0929 Zoe0929 deleted the feat/#89/AddApp branch January 16, 2024 06:59
Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고햇슴니다 zeo~

Comment on lines +88 to +89
case .getdailyChallenge:
return .requestPlain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저히 get, set 지양티비~

Comment on lines +38 to 42
self.setRootViewController(rootViewController)

}

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이거 딱걸린건데 ㅋ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌈 feat 기능 구현 🐰지희 지희의 issue 📡 network api 작업
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Network] 챌린지 관련 서버 통신
3 participants