Feat [#36] 스크린타임 API 연결 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kim-seonwoo
approved these changes
Jan 13, 2024
Comment on lines
+15
to
+39
|
|
||
| private let goalTimeView = GoalTimeSelectView() | ||
|
|
||
| override func loadView() { | ||
| self.view = goalTimeView | ||
| } | ||
|
|
||
| override func viewDidLoad() { | ||
| configureViewController() | ||
|
|
||
| super.viewDidLoad() | ||
| } | ||
|
|
||
| private func configureViewController() { | ||
| mainTitleText = StringLiteral.Challenge.GoalTime.titleText | ||
| subTitleText = StringLiteral.Challenge.GoalTime.subTitleText | ||
| nextButton.setTitle("완료", for: .normal) | ||
| step = 6 | ||
| } | ||
|
|
||
| override func onTapButton() { | ||
| self.navigationController?.popToRootViewController(animated: false) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
p5. 이 부분 전 뷰와의 연결을 위해 추후에 제가 수정해도 될까요?
Comment on lines
14
to
43
| class GoalTimeSelectView: UIView { | ||
|
|
||
| var screenTime = ScreenTime.shared | ||
| private let picker = SpecificTimePickerView() | ||
|
|
||
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
| setUI() | ||
| configureView() | ||
|
|
||
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
| private func setUI(){ | ||
| setHierarchy() | ||
| setConstraints() | ||
| } | ||
|
|
||
| private func setHierarchy() { | ||
| self.addSubviews(picker) | ||
| } | ||
|
|
||
| private func setConstraints() { | ||
| picker.snp.makeConstraints { | ||
| $0.center.equalToSuperview() | ||
| $0.width.equalTo(335.adjusted) | ||
| } | ||
| } |
There was a problem hiding this comment.
p5. 이 부분도 totalPickerView와의 통일성을 위해서 수정이 필요할 것 같습니다!
boyeon0119
approved these changes
Jan 13, 2024
HMH_iOS/HMH_iOS/Presentation/Challenge/Cells/HeaderFooterView/TitleCollectionReusableView.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Challenge/ViewControllers/ChallengeViewController.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Challenge/Views/ChallengeView.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Challenge/Views/GoalTimeSelectView.swift
Outdated
Show resolved
Hide resolved
HMH_iOS/HMH_iOS/Presentation/Challenge/Views/GoalTimeSelectView.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+16
to
+17
| private let authorizationCenter = AuthorizationCenter.shared | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
스크린타임 API 연결을 위한 세팅을 완료했습니다.
🚀 PR Point
아직 미완성입니다!!!
브랜치가 너무 오래되어 한번 끊고 코드리뷰 받으려 합니다.
Shield/ShieldConfig: 이용 시간 완료 후 잠금 뷰에 대한 커스텀을 위해 필요한 Target 입니다. (추가완료)ViewWillAppear(: )에서 호출됩니다.HMH-iOS/HMH_iOS/HMH_iOS/Presentation/Common/CustomTabbar/TabBarController.swift
Lines 132 to 144 in f170ed1
📸 스크린샷
🚀 기기 대응
✅ Issue
Resolved #36