Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat [#28] onboardingbaseViewController 구현 및 프로그래스바 방식 수정 #33

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

kim-seonwoo
Copy link
Member

👾 작업 내용

  • 온보딩에 재활용이 널리 되는 OnboardingBaseViewController를 제작하였습니다.
  • 프로그래스 바를 기존 방식에서 싱글톤 방식과 같이 수정하였습니다.
  • 방식 수정에 따라 ProgressBarManager 파일을 생성하여 하나로 집중 관리 합니다.
class ProgressBarManager {
    static let shared = ProgressBarManager()
    let progressBarView = OnboardingProgressView()
  • 뷰컨트롤러에서 다음과 같이 호출하여 사용합니다.
  let progressBar = ProgressBarManager.shared.progressBarView
  • 역방향으로 프로그래스 바가 감소하는 애니메이션도 구현하였습니다.
  • didset 분기 처리에 따른 애니메이션 타입을 결정합니다.
    var progressAmount: Int = 0 {
        didSet {
            if oldValue > progressAmount {
                removeProgressBar()
            } else {
                addProgressBar()
            }
        }
    }

🚀 PR Point

  • 뷰의 생명주기에 따라 처리를 잘해야할 것 같습니다.

📸 스크린샷

  • 네비바 레이아웃 업데이트 전 입니다.
구현 내용 스크린샷
화면종류

✅ Issue

Resolved #28

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue 🌈 feat 기능 구현 labels Jan 8, 2024
@kim-seonwoo kim-seonwoo added this to the 🚀1차 스프린트🚀 milestone Jan 8, 2024
@kim-seonwoo kim-seonwoo self-assigned this Jan 8, 2024
@kim-seonwoo kim-seonwoo linked an issue Jan 8, 2024 that may be closed by this pull request
@kim-seonwoo kim-seonwoo force-pushed the feat/#28-OnboardingBaseViewController branch from cf910ad to 6a61e14 Compare January 8, 2024 16:58
Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1. 고생하셨습니다!

Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘의 교훈: 생명주기를 확실히 공부하자.

Comment on lines 45 to 49
func setHierarchy() {
view.addSubviews(navigationBar, nextButton, progressBar)
}

func setConstraints() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1. private 가시죠

}
}

func setTarget() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도요

Copy link
Member

@Zoe0929 Zoe0929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 🚀

@kim-seonwoo kim-seonwoo merged commit 710802a into develop Jan 9, 2024
@kim-seonwoo kim-seonwoo deleted the feat/#28-OnboardingBaseViewController branch January 9, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌈 feat 기능 구현 😎선우 선우의 issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] OnboardingBaseViewController UI 구현
3 participants