Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [#108] Challenge 특정 앱 삭제 Alert 구현 #109

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Fix [#108] Challenge 특정 앱 삭제 Alert 구현 #109

merged 9 commits into from
Jan 19, 2024

Conversation

kim-seonwoo
Copy link
Member

👾 작업 내용

  • AlertViewController에 deleteAlert에 관한 case를 추가하여 커스텀으로 사용할 수 있게 하였습니다.
  • 1-6 시간으로 기존 총 시간을 설정할 수 있었던 부분에서, 2-6 시간으로 바꾸었습니다.
  • AlertDelegate로 DeleteAlert의 확인 버튼을 누르면 해당 함수가 실행되게 하였습니다.
    func deleteButtonTapped() {
        let challengeController = ChallengeViewController()
        challengeController.deleteTap()
        dismiss(animated: false) {
            (self.okAction ?? self.emptyActions)()
        }
    }
  • 챌린지 컨트롤러의 deleteTap함수를 실행시키고, alert창이 dismiss 됩니다.
  • deleteTap함수의 구현부는 일단 print문으로 찍히는 것 까지만 구현했습니다.
  • API 연결 부와 합쳐서 delete를 누르면 특정 앱 삭제에 대한 동작과 cell을 리로드 시켜주는 부분이 있으면 될 것 같습니다.

🚀 PR Point

  • 데이터를 어떻게 뿌릴지 공유 부탁드릴게요!

📸 스크린샷

구현 내용 스크린샷
화면종류 image

🚀 기기 대응

기기명 Iphone 13 mini Iphone 15 pro Iphone 14 Iphone SE(3rd)
스크린샷 image image

✅ Issue

Resolved #108

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue 🐞fix 오류 고치는 것 / 수정용 labels Jan 18, 2024
@kim-seonwoo kim-seonwoo added this to the 🚀1차 스프린트🚀 milestone Jan 18, 2024
@kim-seonwoo kim-seonwoo self-assigned this Jan 18, 2024
@kim-seonwoo kim-seonwoo linked an issue Jan 18, 2024 that may be closed by this pull request
[Fix] Alert 버튼 배치 String 부분 수정 #108
Closed
boyeon0119
boyeon0119 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

700a10ae-af14-4811-87f2-4552a4929772
앞으로 고집 부리지 말자! (Feat. 타노스)

HMH_iOS/HMH_iOS/Presentation/Challenge/ViewControllers/ChallengeViewController.swift
@@ -93,6 +97,8 @@ extension ChallengeViewController: UICollectionViewDelegate {
}

func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
self.decodedIndex = indexPath.item
print(decodedIndex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2. 와이 유 남김?

HMH_iOS/HMH_iOS/Presentation/Common/CustomAlert/AlertViewController.swift
@@ -12,6 +12,7 @@ enum AlertType {
case HMHQuitALert
case HMHPushALert
case Challenge
case delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 근데요 혹시 첫글자 대문자 어더신지?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 여기 제가 전체적으로 네이밍 통일했습니다.

HMH_iOS/HMH_iOS/Presentation/Common/CustomAlert/HMHDeleteAlert.swift
$0.font = .iosText5Medium16
$0.textAlignment = .center
$0.numberOfLines = 2
$0.text = "정말 인스타그램" + StringLiteral.AlertTitle.delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 "정말 인스타그램" 걍 넣어놓으신거죠?

Zoe0929
Zoe0929 approved these changes Jan 19, 2024
View reviewed changes
HMH_iOS/HMH_iOS/Presentation/Challenge/ViewControllers/ChallengeViewController.swift Outdated
Comment on lines 123 to 124


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 빈줄 삭제 부탁드립니다 ◡̈

HMH_iOS/HMH_iOS/Presentation/Common/CustomAlert/AlertViewController.swift
@@ -12,6 +12,7 @@ enum AlertType {
case HMHQuitALert
case HMHPushALert
case Challenge
case delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 여기 제가 전체적으로 네이밍 통일했습니다.

@kim-seonwoo kim-seonwoo merged commit 77e0e27 into develop Jan 19, 2024
@Zoe0929 Zoe0929 deleted the fix/#108-Alert branch January 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoe0929 Zoe0929 Zoe0929 approved these changes

@boyeon0119 boyeon0119 boyeon0119 approved these changes

Assignees

@kim-seonwoo kim-seonwoo

Labels
🐞fix 오류 고치는 것 / 수정용 😎선우 선우의 issue
Projects
HMH-iOS AppJam Team Plan
Status: Done
Milestone
🚀1차 스프린트🚀
Development

Successfully merging this pull request may close these issues.

[Fix] Alert 버튼 배치 String 부분 수정
3 participants
@kim-seonwoo @Zoe0929 @boyeon0119