-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat [#102] Challenge 화면 챌린지 생성 경우 구현 #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
} | ||
|
||
private func setConstraints() { | ||
grayBackgroundView.snp.makeConstraints { | ||
$0.leading.trailing.bottom.equalToSuperview() | ||
$0.leading.trailing.equalToSuperview() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. horizontalEdge로 하는건 어떠신지?
$0.top.equalToSuperview().offset(-200) | ||
} | ||
|
||
backgroundImageView.snp.makeConstraints { | ||
$0.leading.trailing.bottom.equalTo(grayBackgroundView) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 이것도 호리즌탈엣지 어떠신지
@@ -52,13 +48,18 @@ final class ChallengeViewController: UIViewController { | |||
} | |||
|
|||
private func setViewHierarchy() { | |||
view.addSubviews(navigationBar) | |||
view.addSubviews(navigationBar, challengeView) | |||
} | |||
|
|||
private func setConstraints() { | |||
navigationBar.snp.makeConstraints { | |||
$0.top.leading.trailing.equalToSuperview() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 호리즌탈엣지 어떠신지
|
||
challengeView.snp.makeConstraints { | ||
$0.top.equalTo(navigationBar.snp.bottom) | ||
$0.leading.trailing.bottom.equalToSuperview() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5. 호리즌탈엣지 어떠신지
challengeViewController.onTabButton() | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2. 빈 줄 지워주세여
👾 작업 내용
🚀 PR Point
📸 스크린샷
🚀 기기 대응
✅ Issue
Resolved #102